You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by "Ashish Vaidya (JIRA)" <ji...@apache.org> on 2012/07/21 01:37:33 UTC
[jira] [Created] (OOZIE-919) Notify user correctly of NN and JT
hostname validity
Ashish Vaidya created OOZIE-919:
-----------------------------------
Summary: Notify user correctly of NN and JT hostname validity
Key: OOZIE-919
URL: https://issues.apache.org/jira/browse/OOZIE-919
Project: Oozie
Issue Type: Improvement
Components: core
Reporter: Ashish Vaidya
Priority: Minor
When value provided for JT and/or NN is malformed (incorrect scheme://hostname:port syntax), we throw the following error: 'Jobtracker/namenode not in whitelist.'
This is misleading to the user. We should let the user know that the input for those is malformed and the hostname:port syntax needs to be corrected.
Above doesn't (and shouldn't) affect the tallying of those values against the respective white lists.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (OOZIE-919) Notify user correctly of NN and JT
hostname validity
Posted by "Ashish Vaidya (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashish Vaidya updated OOZIE-919:
--------------------------------
Attachment: OOZIE-919.WIP.patch
This is a work in progress. I'm trying to use java.net.URI to validate the JT/NN syntax. I'm, however, finding it inadequate and perhaps misleading to get the job done. Or may be it's just that I'm getting back to Java after a while!
>From the current usage I see that we should honor the following formats:
a. scheme://host:port
b. scheme://host
c. host:port
d. host
... and anything else should be rejected.
java.net.URI seems not a perfect choice to get the above job done. If there are better alternatives, suggestions for those are certainly welcome.
For future proofing we should also look at including IPv6 host addresses in the mix.
> Notify user correctly of NN and JT hostname validity
> ----------------------------------------------------
>
> Key: OOZIE-919
> URL: https://issues.apache.org/jira/browse/OOZIE-919
> Project: Oozie
> Issue Type: Improvement
> Components: core
> Reporter: Ashish Vaidya
> Priority: Minor
> Attachments: OOZIE-919.WIP.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> When value provided for JT and/or NN is malformed (incorrect scheme://hostname:port syntax), we throw the following error: 'Jobtracker/namenode not in whitelist.'
> This is misleading to the user. We should let the user know that the input for those is malformed and the hostname:port syntax needs to be corrected.
> Above doesn't (and shouldn't) affect the tallying of those values against the respective white lists.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-919) Notify user correctly of NN and JT
hostname validity
Posted by "Ashish Vaidya (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13420948#comment-13420948 ]
Ashish Vaidya commented on OOZIE-919:
-------------------------------------
Not sure how RegExp fare in Java, but we could try that here if perf isn't a big issue.
> Notify user correctly of NN and JT hostname validity
> ----------------------------------------------------
>
> Key: OOZIE-919
> URL: https://issues.apache.org/jira/browse/OOZIE-919
> Project: Oozie
> Issue Type: Improvement
> Components: core
> Affects Versions: trunk
> Reporter: Ashish Vaidya
> Priority: Minor
> Labels: validation
> Fix For: trunk
>
> Attachments: OOZIE-919.WIP.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> When value provided for JT and/or NN is malformed (incorrect scheme://hostname:port syntax), we throw the following error: 'Jobtracker/namenode not in whitelist.'
> This is misleading to the user. We should let the user know that the input for those is malformed and the hostname:port syntax needs to be corrected.
> Above doesn't (and shouldn't) affect the tallying of those values against the respective white lists.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-919) Notify user correctly of NN and JT
hostname validity
Posted by "Alejandro Abdelnur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13422659#comment-13422659 ]
Alejandro Abdelnur commented on OOZIE-919:
------------------------------------------
why not URI? it does all the right checks.
#c and #d, AFAIK, are not valid HDFS URIs, are they? and even in the case they are, we cannot use them because then we could differentiate a relative path (foo/bar) from a path with authority and no scheme (host/bar).
> Notify user correctly of NN and JT hostname validity
> ----------------------------------------------------
>
> Key: OOZIE-919
> URL: https://issues.apache.org/jira/browse/OOZIE-919
> Project: Oozie
> Issue Type: Improvement
> Components: core
> Affects Versions: trunk
> Reporter: Ashish Vaidya
> Priority: Minor
> Labels: validation
> Fix For: trunk
>
> Attachments: OOZIE-919.WIP.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> When value provided for JT and/or NN is malformed (incorrect scheme://hostname:port syntax), we throw the following error: 'Jobtracker/namenode not in whitelist.'
> This is misleading to the user. We should let the user know that the input for those is malformed and the hostname:port syntax needs to be corrected.
> Above doesn't (and shouldn't) affect the tallying of those values against the respective white lists.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-919) Notify user correctly of NN and JT
hostname validity
Posted by "Ashish Vaidya (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13439738#comment-13439738 ]
Ashish Vaidya commented on OOZIE-919:
-------------------------------------
This isn't done yet.
Hadoop QA:
Please don't pick this up.. no point in testing something that's not done. This is a low priority feature... so not sure on ETA.
> Notify user correctly of NN and JT hostname validity
> ----------------------------------------------------
>
> Key: OOZIE-919
> URL: https://issues.apache.org/jira/browse/OOZIE-919
> Project: Oozie
> Issue Type: Improvement
> Components: core
> Affects Versions: trunk
> Reporter: Ashish Vaidya
> Priority: Minor
> Labels: validation
> Fix For: trunk
>
> Attachments: OOZIE-919.WIP.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> When value provided for JT and/or NN is malformed (incorrect scheme://hostname:port syntax), we throw the following error: 'Jobtracker/namenode not in whitelist.'
> This is misleading to the user. We should let the user know that the input for those is malformed and the hostname:port syntax needs to be corrected.
> Above doesn't (and shouldn't) affect the tallying of those values against the respective white lists.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-919) Notify user correctly of NN and JT
hostname validity
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13439256#comment-13439256 ]
Hadoop QA commented on OOZIE-919:
---------------------------------
Testing JIRA OOZIE-919
{code}
----------------------------
> Notify user correctly of NN and JT hostname validity
> ----------------------------------------------------
>
> Key: OOZIE-919
> URL: https://issues.apache.org/jira/browse/OOZIE-919
> Project: Oozie
> Issue Type: Improvement
> Components: core
> Affects Versions: trunk
> Reporter: Ashish Vaidya
> Priority: Minor
> Labels: validation
> Fix For: trunk
>
> Attachments: OOZIE-919.WIP.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> When value provided for JT and/or NN is malformed (incorrect scheme://hostname:port syntax), we throw the following error: 'Jobtracker/namenode not in whitelist.'
> This is misleading to the user. We should let the user know that the input for those is malformed and the hostname:port syntax needs to be corrected.
> Above doesn't (and shouldn't) affect the tallying of those values against the respective white lists.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OOZIE-919) Notify user correctly of NN and JT
hostname validity
Posted by "Mona Chitnis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OOZIE-919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13439879#comment-13439879 ]
Mona Chitnis commented on OOZIE-919:
------------------------------------
Hadoop QA will pick it up if JIRA is marked 'patch available'. If this is still WIP, you can remove that flag
> Notify user correctly of NN and JT hostname validity
> ----------------------------------------------------
>
> Key: OOZIE-919
> URL: https://issues.apache.org/jira/browse/OOZIE-919
> Project: Oozie
> Issue Type: Improvement
> Components: core
> Affects Versions: trunk
> Reporter: Ashish Vaidya
> Priority: Minor
> Labels: validation
> Fix For: trunk
>
> Attachments: OOZIE-919.WIP.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> When value provided for JT and/or NN is malformed (incorrect scheme://hostname:port syntax), we throw the following error: 'Jobtracker/namenode not in whitelist.'
> This is misleading to the user. We should let the user know that the input for those is malformed and the hostname:port syntax needs to be corrected.
> Above doesn't (and shouldn't) affect the tallying of those values against the respective white lists.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira