You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2017/09/13 20:50:27 UTC
Review Request 62302: Moved docker volume isolator doc to the
isolators folder.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62302/
-----------------------------------------------------------
Review request for mesos, Gilbert Song and James Peach.
Repository: mesos
Description
-------
Moved docker volume isolator doc to the isolators folder.
Diffs
-----
docs/docker-volume.md a8cb099e9c586a57793e0e40616165f710204d7c
docs/home.md dcb6235fdb12593fe8e9416c862ee547c0d77242
docs/mesos-containerizer.md feaaa556c9646435c6c9d677569962576ebf4c74
Diff: https://reviews.apache.org/r/62302/diff/1/
Testing
-------
Thanks,
Jie Yu
Re: Review Request 62302: Moved docker volume isolator doc to the
isolators folder.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62302/#review185595
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On Sept. 15, 2017, 6:46 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62302/
> -----------------------------------------------------------
>
> (Updated Sept. 15, 2017, 6:46 p.m.)
>
>
> Review request for mesos, Gilbert Song and James Peach.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Moved docker volume isolator doc to the isolators folder.
>
>
> Diffs
> -----
>
> docs/docker-volume.md a8cb099e9c586a57793e0e40616165f710204d7c
> docs/home.md dcb6235fdb12593fe8e9416c862ee547c0d77242
> docs/mesos-containerizer.md feaaa556c9646435c6c9d677569962576ebf4c74
>
>
> Diff: https://reviews.apache.org/r/62302/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 62302: Moved docker volume isolator doc to the
isolators folder.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62302/
-----------------------------------------------------------
(Updated Sept. 16, 2017, 1:46 a.m.)
Review request for mesos, Gilbert Song and James Peach.
Changes
-------
Addressed comments.
Repository: mesos
Description
-------
Moved docker volume isolator doc to the isolators folder.
Diffs (updated)
-----
docs/docker-volume.md a8cb099e9c586a57793e0e40616165f710204d7c
docs/home.md dcb6235fdb12593fe8e9416c862ee547c0d77242
docs/mesos-containerizer.md feaaa556c9646435c6c9d677569962576ebf4c74
Diff: https://reviews.apache.org/r/62302/diff/2/
Changes: https://reviews.apache.org/r/62302/diff/1-2/
Testing
-------
Thanks,
Jie Yu
Re: Review Request 62302: Moved docker volume isolator doc to the
isolators folder.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62302/#review185429
-----------------------------------------------------------
docs/docker-volume.md
Line 291 (original), 291 (patched)
<https://reviews.apache.org/r/62302/#comment261740>
The CamelCasing in DockerContainerizer and MesosContainerizer is a bit strange, how about just "Docker containerizer" and "Meso containerizer"?
- James Peach
On Sept. 13, 2017, 8:50 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62302/
> -----------------------------------------------------------
>
> (Updated Sept. 13, 2017, 8:50 p.m.)
>
>
> Review request for mesos, Gilbert Song and James Peach.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Moved docker volume isolator doc to the isolators folder.
>
>
> Diffs
> -----
>
> docs/docker-volume.md a8cb099e9c586a57793e0e40616165f710204d7c
> docs/home.md dcb6235fdb12593fe8e9416c862ee547c0d77242
> docs/mesos-containerizer.md feaaa556c9646435c6c9d677569962576ebf4c74
>
>
> Diff: https://reviews.apache.org/r/62302/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jie Yu
>
>