You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pdfbox.apache.org by Takashi Komatsubara <ta...@sendmail.com> on 2009/03/02 16:21:14 UTC

RE: [jira] Commented: (PDFBOX-420) Japanese Characters are garbled.

Jukka,

I have tried to contact with Pin Xue, have never got any response from him.
The patches he provided was at the sourceforge, and I have no relationship with him.
My work was collect cjk patches and fixes some tiny issues.

There is no possibilities to get his permission.
So, please ignore this patches and forget to support CJK by the Apache PDFBox.

If I have sometime to create my original CJK patches or someone contribute that kind of patches, that't the time we start to think to support CJK for Korea/China/Japanese people.

Thank you,
Takashi.



-----Original Message-----
From: Jukka Zitting (JIRA) [mailto:jira@apache.org] 
Sent: Tuesday, February 17, 2009 7:23 PM
To: pdfbox-dev@incubator.apache.org
Subject: [jira] Commented: (PDFBOX-420) Japanese Characters are garbled.


    [ https://issues.apache.org/jira/browse/PDFBOX-420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12674167#action_12674167 ] 

Jukka Zitting commented on PDFBOX-420:
--------------------------------------

If you can, please try contacting Pin Xue again to get his confirmation on contributing this under the Apache license.

How/why did you work together on this? If you share an employer and wrote this patch at work, then an OK from your manager is typically enough and often necessary, depending on the copyright terms of the employment contract.

How much of the code is written by Pin Xue? We can include the code under the BSD license, but that requires special mentioning in the LICENSE and NOTICE files that we and all the downstream projects need to worry about. So if it's just a few lines of code then we're probably better off by just rewriting them if we can't get an OK for the Apache license.

> Japanese Characters are garbled.
> --------------------------------
>
>                 Key: PDFBOX-420
>                 URL: https://issues.apache.org/jira/browse/PDFBOX-420
>             Project: PDFBox
>          Issue Type: Bug
>          Components: Text extraction
>    Affects Versions: 0.8.0-incubator
>            Reporter: Takashi Komatsubara
>            Priority: Critical
>         Attachments: supportJapanese-fontbox.patch, supportJapanese.patch, TestFilesForJapaneseGarbledIssue.zip
>
>
> The extracted Japanese characters are completely garbled.
> This issue is very critical for Japanese users.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.



Re: [jira] Commented: (PDFBOX-420) Japanese Characters are garbled.

Posted by Andreas Lehmkühler <an...@lehmi.de>.
Hi,

> Let me know when I can do test the CJK support improvement.
> I will confirm what is lack and where should be improved.
For the moment I'm short of time but I'll try to include the patch soon.
I've already patched my local installation. There have to be done some
more improvements to support chinese and korean as well. But I'm on it ...

Andreas Lehmkühler

RE: [jira] Commented: (PDFBOX-420) Japanese Characters are garbled.

Posted by Takashi Komatsubara <ta...@sendmail.com>.
Jukka,

Thank you so much.

Let me know when I can do test the CJK support improvement.
I will confirm what is lack and where should be improved.

Takashi.


-----Original Message-----
From: Jukka Zitting [mailto:jukka.zitting@gmail.com] 
Sent: Tuesday, March 03, 2009 11:09 PM
To: pdfbox-dev@incubator.apache.org; takashi@sendmail.com
Subject: Re: [jira] Commented: (PDFBOX-420) Japanese Characters are garbled.

Hi,

On Tue, Mar 3, 2009 at 2:53 PM, Takashi Komatsubara
<ta...@sendmail.com> wrote:
> Here is the URL from which we can get the patch.
>
https://sourceforge.net/tracker/index.php?func=detail&aid=1640071&group_id=7
> 8314&atid=552834

OK, good. That issue was imported to Jira as issue PDFBOX-238. I've
added the reference to PDFBOX-420, so as far as I'm concerned we now
have the required paper trail in place for applying this patch to
trunk.

BR,

Jukka Zitting


Re: [jira] Commented: (PDFBOX-420) Japanese Characters are garbled.

Posted by Jukka Zitting <ju...@gmail.com>.
Hi,

On Tue, Mar 3, 2009 at 2:53 PM, Takashi Komatsubara
<ta...@sendmail.com> wrote:
> Here is the URL from which we can get the patch.
> https://sourceforge.net/tracker/index.php?func=detail&aid=1640071&group_id=7
> 8314&atid=552834

OK, good. That issue was imported to Jira as issue PDFBOX-238. I've
added the reference to PDFBOX-420, so as far as I'm concerned we now
have the required paper trail in place for applying this patch to
trunk.

BR,

Jukka Zitting

RE: [jira] Commented: (PDFBOX-420) Japanese Characters are garbled.

Posted by Takashi Komatsubara <ta...@sendmail.com>.
Hi Jukka,

Thank you for your kindness.

Here is the URL from which we can get the patch.
https://sourceforge.net/tracker/index.php?func=detail&aid=1640071&group_id=7
8314&atid=552834

Regards,
Takashi.

-----Original Message-----
From: Jukka Zitting [mailto:jukka.zitting@gmail.com] 
Sent: Tuesday, March 03, 2009 5:52 AM
To: pdfbox-dev@incubator.apache.org
Subject: Re: [jira] Commented: (PDFBOX-420) Japanese Characters are garbled.

Hi,

On Mon, Mar 2, 2009 at 4:21 PM, Takashi Komatsubara
<ta...@sendmail.com> wrote:
> I have tried to contact with Pin Xue, have never got any response from
him.
> The patches he provided was at the sourceforge, and I have no relationship
with him.
> My work was collect cjk patches and fixes some tiny issues.

OK, thanks for the background.

> There is no possibilities to get his permission. So, please ignore this
> patches and forget to support CJK by the Apache PDFBox.

Do you have references to the original submissions in SourceForge? We
already have a generic entry in the legal documentation of Apache
PDFBox that covers all BSD-licensed contributions to past PDFBox
versions. This should cover also Pin Xue's work, but it would be good
to have a record of what was contributed and where before we include
the code.

BR,

Jukka Zitting


Re: [jira] Commented: (PDFBOX-420) Japanese Characters are garbled.

Posted by Jukka Zitting <ju...@gmail.com>.
Hi,

On Mon, Mar 2, 2009 at 4:21 PM, Takashi Komatsubara
<ta...@sendmail.com> wrote:
> I have tried to contact with Pin Xue, have never got any response from him.
> The patches he provided was at the sourceforge, and I have no relationship with him.
> My work was collect cjk patches and fixes some tiny issues.

OK, thanks for the background.

> There is no possibilities to get his permission. So, please ignore this
> patches and forget to support CJK by the Apache PDFBox.

Do you have references to the original submissions in SourceForge? We
already have a generic entry in the legal documentation of Apache
PDFBox that covers all BSD-licensed contributions to past PDFBox
versions. This should cover also Pin Xue's work, but it would be good
to have a record of what was contributed and where before we include
the code.

BR,

Jukka Zitting