You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2018/06/26 08:35:39 UTC

[GitHub] flink pull request #6210: [FLINK-9659][tests] Replace hard-coded sleeps

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/6210

    [FLINK-9659][tests] Replace hard-coded sleeps

    This PR replaces hard-coded sleeps in the bucketing sink end-to-end test.
    
    Instead we use utility functions to wait for specific events, in this case some progress in the job (measured by number of checkpoints) and the job finishing (by waiting for FINISHED state).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 9659

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6210.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6210
    
----
commit 15afce5b32968905972aaffd72b1f6deb126b99f
Author: zentol <ch...@...>
Date:   2018-06-25T20:19:02Z

    [FLINK-9659][tests] Replace hard-coded sleeps

----


---

[GitHub] flink issue #6210: [FLINK-9659][tests] Replace hard-coded sleeps

Posted by twalthr <gi...@git.apache.org>.

Github user twalthr commented on the issue:

    https://github.com/apache/flink/pull/6210
  
    After knowing that we have to use the `run-single-test.sh` script. I could also run this successfully. Will merge this...


---

[GitHub] flink pull request #6210: [FLINK-9659][tests] Replace hard-coded sleeps

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/6210


---

[GitHub] flink issue #6210: [FLINK-9659][tests] Replace hard-coded sleeps

Posted by zentol <gi...@git.apache.org>.

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/6210
  
    Could it be that you didn't wait long enough? We do after all replace a 100 _second_ sleep.
    
    What error do you get?


---

[GitHub] flink issue #6210: [FLINK-9659][tests] Replace hard-coded sleeps

Posted by twalthr <gi...@git.apache.org>.

Github user twalthr commented on the issue:

    https://github.com/apache/flink/pull/6210
  
    I tried your changes both rebased on current master and unrebased. But the test is not runnable anymore. It gets stuck. Was it runnable on your machine?
    
    Even with the current master the tests seems to fail now on my machine with an error.


---