You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2021/07/28 20:25:36 UTC

[GitHub] [gobblin] sv2000 commented on a change in pull request #3343: [GOBBLIN-1499] fix the bug that compaction job hang when there is no fix the bug that compaction job hang when there is no path match the datasets patten

sv2000 commented on a change in pull request #3343:
URL: https://github.com/apache/gobblin/pull/3343#discussion_r678627051



##########
File path: gobblin-hive-registration/src/main/java/org/apache/gobblin/hive/writer/HiveMetadataWriter.java
##########
@@ -292,9 +292,9 @@ private void schemaUpdateHelper(GobblinMetadataChangeEvent gmce, HiveSpec spec,
       return;
     }
     //Force to set the schema even there is no schema literal defined in the spec
-    spec.getTable()
-        .getSerDeProps()
-        .setProp(AvroSerdeUtils.AvroTableProperties.SCHEMA_LITERAL.getPropName(), latestSchemaMap.get(tableKey));
+    if(latestSchemaMap.containsKey(tableKey)) {

Review comment:
       This change looks unrelated to the PR. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org