You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2024/12/02 20:22:41 UTC
[kudu-CR] [build-support-test] remove TEST TMPDIR with its content
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22150
Change subject: [build-support-test] remove TEST_TMPDIR with its content
......................................................................
[build-support-test] remove TEST_TMPDIR with its content
In case of concurrent build/test tasks, it makes sense to create
per-task TEST_TMPDIR directory because of the logic in the
jenkins/build-and-test.sh script that introspects its content.
When doing so, it make sense to remove the directory along with its
content, not just the content under the directory. Otherwise,
an empty TEST_TMPDIR directory would be left behind. It's not an
issue when TEST_TMPDIR is the same for every build/task, but with
custom, per-build TEST_TMPDIR, there would be too many empty directories
left behind.
With this patch, the script is amended to address that: as a part
of clean-up, it now removes the TEST_TMPDIR directory along with its
content, not just the content of the directory.
Change-Id: I1d79f9482575fecba2e81c2d5fe85cbe25afd6b5
---
M build-support/jenkins/build-and-test.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/22150/1
--
To view, visit http://gerrit.cloudera.org:8080/22150
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1d79f9482575fecba2e81c2d5fe85cbe25afd6b5
Gerrit-Change-Number: 22150
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] [build-support-test] remove TEST TMPDIR with its content
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22150 )
Change subject: [build-support-test] remove TEST_TMPDIR with its content
......................................................................
Patch Set 1:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/731/
--
To view, visit http://gerrit.cloudera.org:8080/22150
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d79f9482575fecba2e81c2d5fe85cbe25afd6b5
Gerrit-Change-Number: 22150
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 02 Dec 2024 20:22:47 +0000
Gerrit-HasComments: No
[kudu-CR] [build-support-test] remove TEST TMPDIR with its content
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22150 )
Change subject: [build-support-test] remove TEST_TMPDIR with its content
......................................................................
Patch Set 1: Verified+1
unrelated test failures (RELEASE, TSAN)
--
To view, visit http://gerrit.cloudera.org:8080/22150
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d79f9482575fecba2e81c2d5fe85cbe25afd6b5
Gerrit-Change-Number: 22150
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 02 Dec 2024 21:59:09 +0000
Gerrit-HasComments: No
[kudu-CR] [build-support-test] remove TEST TMPDIR with its content
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22150 )
Change subject: [build-support-test] remove TEST_TMPDIR with its content
......................................................................
[build-support-test] remove TEST_TMPDIR with its content
In case of concurrent build/test tasks, it makes sense to create
per-task TEST_TMPDIR directory because of the logic in the
jenkins/build-and-test.sh script that introspects its content.
When doing so, it make sense to remove the directory along with its
content, not just the content under the directory. Otherwise,
an empty TEST_TMPDIR directory would be left behind. It's not an
issue when TEST_TMPDIR is the same for every build/task, but with
custom, per-build TEST_TMPDIR, there would be too many empty directories
left behind.
With this patch, the script is amended to address that: as a part
of clean-up, it now removes the TEST_TMPDIR directory along with its
content, not just the content of the directory.
Change-Id: I1d79f9482575fecba2e81c2d5fe85cbe25afd6b5
Reviewed-on: http://gerrit.cloudera.org:8080/22150
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
Tested-by: Alexey Serbin <al...@apache.org>
---
M build-support/jenkins/build-and-test.sh
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Abhishek Chennaka: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/22150
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I1d79f9482575fecba2e81c2d5fe85cbe25afd6b5
Gerrit-Change-Number: 22150
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [build-support-test] remove TEST TMPDIR with its content
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22150 )
Change subject: [build-support-test] remove TEST_TMPDIR with its content
......................................................................
Patch Set 1: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/731/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/22150
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d79f9482575fecba2e81c2d5fe85cbe25afd6b5
Gerrit-Change-Number: 22150
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 02 Dec 2024 21:17:10 +0000
Gerrit-HasComments: No
[kudu-CR] [build-support-test] remove TEST TMPDIR with its content
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/22150 )
Change subject: [build-support-test] remove TEST_TMPDIR with its content
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/22150
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d79f9482575fecba2e81c2d5fe85cbe25afd6b5
Gerrit-Change-Number: 22150
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 02 Dec 2024 20:38:42 +0000
Gerrit-HasComments: No
[kudu-CR] [build-support-test] remove TEST TMPDIR with its content
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [build-support-test] remove TEST_TMPDIR with its content
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/22150
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I1d79f9482575fecba2e81c2d5fe85cbe25afd6b5
Gerrit-Change-Number: 22150
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)