You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by "Reinhard Poetz (JIRA)" <ji...@codehaus.org> on 2006/03/01 17:22:07 UTC
[jira] Created: (MECLIPSE-71) eclipse:clean delets too much
eclipse:clean delets too much
-----------------------------
Key: MECLIPSE-71
URL: http://jira.codehaus.org/browse/MECLIPSE-71
Project: Maven 2.x Eclipse Plugin
Type: Bug
Versions: 2.1
Reporter: Reinhard Poetz
If I call eclipse:clean, the complete ".settings" directory is deleted. In my projects we share some Eclipse settings in our team by adding the .settings directory to SVN.
This behaviour is unpractical for us as SVN gets confused by the missing ./settings/.svn directory.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MECLIPSE-71) eclipse:clean delets too much
Posted by "fabrizio giustina (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-71?page=comments#action_59814 ]
fabrizio giustina commented on MECLIPSE-71:
-------------------------------------------
what about only deleting the files in the .settings directory that the eclipse plugin also create, ando finally remove such directory only if empty?
I would prefer this solution, instead of an additional configuration property
> eclipse:clean delets too much
> -----------------------------
>
> Key: MECLIPSE-71
> URL: http://jira.codehaus.org/browse/MECLIPSE-71
> Project: Maven 2.x Eclipse Plugin
> Type: Bug
> Versions: 2.1
> Reporter: Reinhard Poetz
>
>
> If I call eclipse:clean, the complete ".settings" directory is deleted. In my projects we share some Eclipse settings in our team by adding the .settings directory to SVN.
> This behaviour is unpractical for us as SVN gets confused by the missing ./settings/.svn directory.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MECLIPSE-71) eclipse:clean delets too much
Posted by "Reinhard Poetz (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-71?page=comments#action_59893 ]
Reinhard Poetz commented on MECLIPSE-71:
----------------------------------------
ok, this makes it even easier :-)
AFAICS, the SettingsWriter writes to org.eclipse.jdt.core.prefs. It doesn't generate the complete file, but reads out the already set parameters and overrides the "o.e.j.c.c.compliance", "o.e.j.c.c.source" and "o.e.j.c.c.target" properties.
The question now is: Should we delete the file or not? In my projects, org.eclipse.jdt.core.prefs is shared via SVN (e.g. to set project specific code styles) and deleting it is problematic and I don't think necessary.
IIUC, the only file within the .settings directory that should get deleted with eclipse:clean is ".settings/.component", which is generated by the EclipseWtpComponentWriter.
I could provide a patch if you want. WDYT?
> eclipse:clean delets too much
> -----------------------------
>
> Key: MECLIPSE-71
> URL: http://jira.codehaus.org/browse/MECLIPSE-71
> Project: Maven 2.x Eclipse Plugin
> Type: Bug
> Versions: 2.1
> Reporter: Reinhard Poetz
>
>
> If I call eclipse:clean, the complete ".settings" directory is deleted. In my projects we share some Eclipse settings in our team by adding the .settings directory to SVN.
> This behaviour is unpractical for us as SVN gets confused by the missing ./settings/.svn directory.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MECLIPSE-71) eclipse:clean delets too much
Posted by "Rahul Thakur (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-71?page=comments#action_60044 ]
Rahul Thakur commented on MECLIPSE-71:
--------------------------------------
I think the eclipse:clean goal should delete any artifacts the maven-eclipse-plugin generates (+1 on Fabrizio's comment above), so stuff under .settings should be cleaned up!
Perhaps a better way to re-create the config/prefs under .settings would be to write a small Mojo specific to your dev environment that can take care of re-creating required files consistently rather than having to control and share them via SVN.
One another solution could be to have an "ignore" list (comma-separated list of paths to resources under the project) that indicates to the eclipse:clean goal which resources to skip when running a 'clean' goal.
What do others think?
> eclipse:clean delets too much
> -----------------------------
>
> Key: MECLIPSE-71
> URL: http://jira.codehaus.org/browse/MECLIPSE-71
> Project: Maven 2.x Eclipse Plugin
> Type: Bug
> Versions: 2.1
> Reporter: Reinhard Poetz
>
>
> If I call eclipse:clean, the complete ".settings" directory is deleted. In my projects we share some Eclipse settings in our team by adding the .settings directory to SVN.
> This behaviour is unpractical for us as SVN gets confused by the missing ./settings/.svn directory.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MECLIPSE-71) eclipse:clean delets too much
Posted by "Reinhard Poetz (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-71?page=comments#action_59810 ]
Reinhard Poetz commented on MECLIPSE-71:
----------------------------------------
My idea was adding a configuration parameter, that makes it possible to add paths that are excluded from deletion.
WDYT?
> eclipse:clean delets too much
> -----------------------------
>
> Key: MECLIPSE-71
> URL: http://jira.codehaus.org/browse/MECLIPSE-71
> Project: Maven 2.x Eclipse Plugin
> Type: Bug
> Versions: 2.1
> Reporter: Reinhard Poetz
>
>
> If I call eclipse:clean, the complete ".settings" directory is deleted. In my projects we share some Eclipse settings in our team by adding the .settings directory to SVN.
> This behaviour is unpractical for us as SVN gets confused by the missing ./settings/.svn directory.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MECLIPSE-71) eclipse:clean delets too much
Posted by "fabrizio giustina (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-71?page=comments#action_59917 ]
fabrizio giustina commented on MECLIPSE-71:
-------------------------------------------
good, if you will provide a patch I will review and apply it ASAP.
anyway, I think that the org.eclipse.jdt.core.prefs file should be deleted, or we never will end up in removing the .settings directory...
The eclipse:clean should delete any configuration file related to eclipse and manipulated by the plugin... if we add a check for the directory to be empty before deleting it we will never delete directories stored in cvs or subversion (due to the CV or .svn subdirs) and I think that it could be enough for solving your problems (svn will report the missing or modified file and update it, but it will not have problems anymore due to a missing directory): if you don't want to delete your old settings but simply update them you can just run eclipse:eclipse without a clean step before...
> eclipse:clean delets too much
> -----------------------------
>
> Key: MECLIPSE-71
> URL: http://jira.codehaus.org/browse/MECLIPSE-71
> Project: Maven 2.x Eclipse Plugin
> Type: Bug
> Versions: 2.1
> Reporter: Reinhard Poetz
>
>
> If I call eclipse:clean, the complete ".settings" directory is deleted. In my projects we share some Eclipse settings in our team by adding the .settings directory to SVN.
> This behaviour is unpractical for us as SVN gets confused by the missing ./settings/.svn directory.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MECLIPSE-71) eclipse:clean delets too much
Posted by "Reinhard Poetz (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MECLIPSE-71?page=comments#action_60229 ]
Reinhard Poetz commented on MECLIPSE-71:
----------------------------------------
Are there any implications if I don't run "eclipse:clean" before I run "eclipse:eclipse"? Is it possible that the plugin creates some inconsistent Eclipse settings files? If no, I agree with you that deleting isn't necessary. (Although Maven delets a file that it doesn't generate *completly* --> org.eclipse.jdt.core.prefs)
I'd propose following cleaning procedure:
- eclipse:clean delets all files it generates/manipulates
- if after deleting these files, something is left (e.g. .svn directory) the .settings directory is _not_ deleted
- if .settings is empty, the .settings directory is deleted too.
WDYT?
> eclipse:clean delets too much
> -----------------------------
>
> Key: MECLIPSE-71
> URL: http://jira.codehaus.org/browse/MECLIPSE-71
> Project: Maven 2.x Eclipse Plugin
> Type: Bug
> Versions: 2.1
> Reporter: Reinhard Poetz
>
>
> If I call eclipse:clean, the complete ".settings" directory is deleted. In my projects we share some Eclipse settings in our team by adding the .settings directory to SVN.
> This behaviour is unpractical for us as SVN gets confused by the missing ./settings/.svn directory.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org