You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@phoenix.apache.org by "Maryann Xue (JIRA)" <ji...@apache.org> on 2015/02/19 20:03:11 UTC
[jira] [Comment Edited] (PHOENIX-1489) Access column values
positionally from client
[ https://issues.apache.org/jira/browse/PHOENIX-1489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14327954#comment-14327954 ]
Maryann Xue edited comment on PHOENIX-1489 at 2/19/15 7:02 PM:
---------------------------------------------------------------
Sure, I'll hold off the check-in. And thanks a lot for the comments, [~jamestaylor]! Just one question:
bq. Similar question in JoinCompiler. Would it make sense to have a method on ColumnRef to prevent the instanceof check here.
You mean we add something like isLocalIndex() to ColumnRef class, right?
I am attaching a new patch with the other two places your pointed out modified and some additional comments. Meanwhile it includes a bug fix for KeyValueSchema: we should make sure ptr length does not exceed maxOffset (which would have no impact on the current master since we do not have tuple projection for simple queries yet).
was (Author: maryannxue):
Sure, I'll hold off the check-in. And thanks a lot for the comments, [~jamestaylor]! Just one question:
bq. Similar question in JoinCompiler. Would it make sense to have a method on ColumnRef to prevent the instanceof check here.
You mean we add something like isLocalIndex() to ColumnRef class, right?
I am attaching a new patch with the other two places your pointed out modified and some additional comments. Meanwhile it includes a bug fix for KeyValueSchema: we should make sure ptr length does not exceed maxOffset.
> Access column values positionally from client
> ---------------------------------------------
>
> Key: PHOENIX-1489
> URL: https://issues.apache.org/jira/browse/PHOENIX-1489
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: James Taylor
> Assignee: Maryann Xue
> Attachments: 1489-2.patch, 1489-v1.patch
>
>
> Instead of passing back separate KeyValues for data returned from the server, we should access via position using our TupleProjector everywhere. This is already the case for joins and aggregate queries, but not for scan queries. We can modify ScanRegionObserver to use our KeyValueSchema to accomplish this.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)