You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by Alexandru Popescu <th...@gmail.com> on 2006/01/31 10:41:27 UTC
[Fwd: [jira] Commented: (JCR-298) missing blob.remove in Berkeley
DB persistance manager]
Hi!
I am wondering if somebody can take a look at this patch and push it in BDB contrib. I know that
you've been busy preparing Jackrabbit for release, and I would appreciate very much your help to
have this fixed.
tia,
./alex
--
.w( the_mindstorm )p.
[ http://issues.apache.org/jira/browse/JCR-298?page=comments#action_12362464 ]
Alexandru Popescu commented on JCR-298:
---------------------------------------
It looks like this part is missing:
[code]
InternalValue[] values = state.getValues();
if (values != null) {
for (int i = 0; i < values.length; i++) {
InternalValue val = values[i];
if (val != null) {
if (val.getType() == PropertyType.BINARY) {
BLOBFileValue blobVal = (BLOBFileValue) val.internalValue();
// delete internal resource representation of BLOB value
blobVal.delete(true);
// also remove from BLOBStore
String blobId = blobStore.createId((PropertyId) state.getId(), i);
try {
blobStore.remove(blobId);
} catch (Exception e) {
log.warn("failed to remove from BLOBStore: " + blobId, e);
}
}
}
}
}
[/code]
./alex
--
.w( the_mindstorm )p.
> missing blob.remove in Berkeley DB persistance manager
> ------------------------------------------------------
>
> Key: JCR-298
> URL: http://issues.apache.org/jira/browse/JCR-298
> Project: Jackrabbit
> Type: Bug
> Versions: 1.0
> Reporter: scharles
> Priority: Minor
>
> org/apache/jackrabbit/core/state/bdb/BerkeleyDBPersistenceManager.destroy(PropertyState state) does not remove binary file from
> the BLOBStore (filesystem impl)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
Re: [Fwd: [jira] Commented: (JCR-298) missing blob.remove in Berkeley
DB persistance manager]
Posted by Alexandru Popescu <th...@gmail.com>.
#: Jukka Zitting changed the world a bit at a time by saying (astral date: 2/2/2006 2:15 PM) :#
> Hi,
>
> On 2/2/06, Alexandru Popescu <th...@gmail.com> wrote:
>> I am watching the SVN commit notifications and I've seen nothing related to this one.
>>
>> Agreed, everybody is busy preparing for the 0.9 - 1.0 which I eagerly wait. Still, I
>> have expected to have at least somebody taking a look at the issue. Should I
>> understand that BDB is deprecated or abandonned?
>
> At least there isn't anyone actively maintaining the BDB PM. It is a
> good practice to always test any external patches before committing
> them, and I suppose that none of the active committers has a BDB PM
> configured for quick testing.
>
> Have you tested that the change works for you? If so, I can just
> commit it directly.
>
> BR,
>
> Jukka Zitting
>
> --
> Yukatan - http://yukatan.fi/ - info@yukatan.fi
> Software craftmanship, JCR consulting, and Java development
Thanks for addressing this Jukka. Unfortunately, I haven't got tests to cover that piece. I assumes
that JCR TCK should cover this part too, so for a developer would be easy to check it. Please let me
know if I need to do it myself, or somebody else can address it.
cheers,
./alex
--
.w( the_mindstorm )p.
Re: [Fwd: [jira] Commented: (JCR-298) missing blob.remove in Berkeley DB persistance manager]
Posted by Jukka Zitting <ju...@gmail.com>.
Hi,
On 2/2/06, Alexandru Popescu <th...@gmail.com> wrote:
> I am watching the SVN commit notifications and I've seen nothing related to this one.
>
> Agreed, everybody is busy preparing for the 0.9 - 1.0 which I eagerly wait. Still, I
> have expected to have at least somebody taking a look at the issue. Should I
> understand that BDB is deprecated or abandonned?
At least there isn't anyone actively maintaining the BDB PM. It is a
good practice to always test any external patches before committing
them, and I suppose that none of the active committers has a BDB PM
configured for quick testing.
Have you tested that the change works for you? If so, I can just
commit it directly.
BR,
Jukka Zitting
--
Yukatan - http://yukatan.fi/ - info@yukatan.fi
Software craftmanship, JCR consulting, and Java development
Re: [Fwd: [jira] Commented: (JCR-298) missing blob.remove in Berkeley
DB persistance manager]
Posted by Alexandru Popescu <th...@gmail.com>.
Hi!
I am watching the SVN commit notifications and I've seen nothing related to this one.
Agreed, everybody is busy preparing for the 0.9 - 1.0 which I eagerly wait. Still, I have expected
to have at least somebody taking a look at the issue. Should I understand that BDB is deprecated or
abandonned?
tia,
./alex
--
.w( the_mindstorm )p.
#: Alexandru Popescu changed the world a bit at a time by saying (astral date: 1/31/2006 11:41 AM) :#
> Hi!
>
> I am wondering if somebody can take a look at this patch and push it in BDB contrib. I know that
> you've been busy preparing Jackrabbit for release, and I would appreciate very much your help to
> have this fixed.
>
>
> tia,
>
> ./alex
> --
> .w( the_mindstorm )p.
>
>
> [ http://issues.apache.org/jira/browse/JCR-298?page=comments#action_12362464 ]
>
> Alexandru Popescu commented on JCR-298:
> ---------------------------------------
>
> It looks like this part is missing:
> [code]
> InternalValue[] values = state.getValues();
> if (values != null) {
> for (int i = 0; i < values.length; i++) {
> InternalValue val = values[i];
> if (val != null) {
> if (val.getType() == PropertyType.BINARY) {
> BLOBFileValue blobVal = (BLOBFileValue) val.internalValue();
> // delete internal resource representation of BLOB value
> blobVal.delete(true);
> // also remove from BLOBStore
> String blobId = blobStore.createId((PropertyId) state.getId(), i);
> try {
> blobStore.remove(blobId);
> } catch (Exception e) {
> log.warn("failed to remove from BLOBStore: " + blobId, e);
> }
> }
> }
> }
> }
> [/code]
>
> ./alex
> --
> .w( the_mindstorm )p.
>
>
>> missing blob.remove in Berkeley DB persistance manager
>> ------------------------------------------------------
>>
>> Key: JCR-298
>> URL: http://issues.apache.org/jira/browse/JCR-298
>> Project: Jackrabbit
>> Type: Bug
>> Versions: 1.0
>> Reporter: scharles
>> Priority: Minor
>
>>
>> org/apache/jackrabbit/core/state/bdb/BerkeleyDBPersistenceManager.destroy(PropertyState state) does not remove binary file from
>> the BLOBStore (filesystem impl)
>