You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/07/09 05:30:20 UTC

[GitHub] [skywalking] wu-sheng commented on a change in pull request #7270: set context class loader to AgentClassLoader

wu-sheng commented on a change in pull request #7270:
URL: https://github.com/apache/skywalking/pull/7270#discussion_r666680985



##########
File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/plugin/loader/AgentClassLoader.java
##########
@@ -77,6 +77,7 @@ public static void initDefaultLoader() throws AgentPackageNotFoundException {
             synchronized (AgentClassLoader.class) {
                 if (DEFAULT_LOADER == null) {
                     DEFAULT_LOADER = new AgentClassLoader(PluginBootstrap.class.getClassLoader());
+                    Thread.currentThread().setContextClassLoader(DEFAULT_LOADER);

Review comment:
       This is only work for current thread, why this effects the Kafka kernel? How they share the same thread?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org