You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/04/08 02:56:55 UTC
[GitHub] [incubator-shardingsphere] ssxlulu opened a new pull request #5099:
Check pgsql's query privilege
ssxlulu opened a new pull request #5099: Check pgsql's query privilege
URL: https://github.com/apache/incubator-shardingsphere/pull/5099
Fixes #3849.
Changes proposed in this pull request:
- check pgsql's query privilege
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #5099:
Check pgsql's query privilege
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #5099: Check pgsql's query privilege
URL: https://github.com/apache/incubator-shardingsphere/pull/5099#issuecomment-610747746
# [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5099?src=pr&el=h1) Report
> Merging [#5099](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5099?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/dc3c69678ef3dfcc49a6a77db199ec9dfddfa8f4&el=desc) will **decrease** coverage by `0.01%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5099?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5099 +/- ##
============================================
- Coverage 53.91% 53.89% -0.02%
Complexity 395 395
============================================
Files 1145 1145
Lines 20340 20360 +20
Branches 3687 3690 +3
============================================
+ Hits 10967 10974 +7
- Misses 8692 8705 +13
Partials 681 681
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5099?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...caling/postgresql/PostgreSQLDataSourceChecker.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5099/diff?src=pr&el=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLXBvc3RncmVzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nc2NhbGluZy9wb3N0Z3Jlc3FsL1Bvc3RncmVTUUxEYXRhU291cmNlQ2hlY2tlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...apache/shardingsphere/shardingproxy/Bootstrap.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5099/diff?src=pr&el=tree#diff-c2hhcmRpbmctcHJveHkvc2hhcmRpbmctcHJveHktYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZ3Byb3h5L0Jvb3RzdHJhcC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...here/shardingproxy/backend/schema/LogicSchema.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5099/diff?src=pr&el=tree#diff-c2hhcmRpbmctcHJveHkvc2hhcmRpbmctcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdwcm94eS9iYWNrZW5kL3NjaGVtYS9Mb2dpY1NjaGVtYS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...ngsphere/orchestration/core/common/CenterType.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5099/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNvcmUvc2hhcmRpbmctb3JjaGVzdHJhdGlvbi1jb3JlLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvb3JjaGVzdHJhdGlvbi9jb3JlL2NvbW1vbi9DZW50ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
| [...ation/core/facade/ShardingOrchestrationFacade.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5099/diff?src=pr&el=tree#diff-c2hhcmRpbmctb3JjaGVzdHJhdGlvbi9zaGFyZGluZy1vcmNoZXN0cmF0aW9uLWNvcmUvc2hhcmRpbmctb3JjaGVzdHJhdGlvbi1jb3JlLWZhY2FkZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvb3JjaGVzdHJhdGlvbi9jb3JlL2ZhY2FkZS9TaGFyZGluZ09yY2hlc3RyYXRpb25GYWNhZGUuamF2YQ==) | `96.07% <0.00%> (+0.62%)` | `0.00% <0.00%> (ø%)` | |
| [...ere/shardingproxy/backend/schema/LogicSchemas.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5099/diff?src=pr&el=tree#diff-c2hhcmRpbmctcHJveHkvc2hhcmRpbmctcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdwcm94eS9iYWNrZW5kL3NjaGVtYS9Mb2dpY1NjaGVtYXMuamF2YQ==) | `33.33% <0.00%> (+2.29%)` | `0.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5099?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5099?src=pr&el=footer). Last update [dc3c696...85b5be3](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5099?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue
#5099: Check pgsql's query privilege
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #5099: Check pgsql's query privilege
URL: https://github.com/apache/incubator-shardingsphere/pull/5099#issuecomment-610748868
## Pull Request Test Coverage Report for [Build 10883](https://coveralls.io/builds/29931616)
* **0** of **11** **(0.0%)** changed or added relevant lines in **1** file are covered.
* **6** unchanged lines in **2** files lost coverage.
* Overall coverage increased (+**0.001%**) to **57.318%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [sharding-scaling/sharding-scaling-postgresql/src/main/java/org/apache/shardingsphere/shardingscaling/postgresql/PostgreSQLDataSourceChecker.java](https://coveralls.io/builds/29931616/source?filename=sharding-scaling%2Fsharding-scaling-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fpostgresql%2FPostgreSQLDataSourceChecker.java#L37) | 0 | 11 | 0.0%
<!-- | **Total:** | **0** | **11** | **0.0%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-scaling/sharding-scaling-postgresql/src/main/java/org/apache/shardingsphere/shardingscaling/postgresql/PostgreSQLDataSourceChecker.java](https://coveralls.io/builds/29931616/source?filename=sharding-scaling%2Fsharding-scaling-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fpostgresql%2FPostgreSQLDataSourceChecker.java#L51) | 1 | 0% |
| [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-metadatacenter/src/main/java/org/apache/shardingsphere/orchestration/core/metadatacenter/MetaDataCenter.java](https://coveralls.io/builds/29931616/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-metadatacenter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fmetadatacenter%2FMetaDataCenter.java#L37) | 5 | 0% |
<!-- | **Total:** | **6** | | -->
| Totals | [](https://coveralls.io/builds/29931616) |
| :-- | --: |
| Change from base [Build 10876](https://coveralls.io/builds/29928409): | 0.001% |
| Covered Lines: | 11678 |
| Relevant Lines: | 20374 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] KomachiSion merged pull request #5099:
Check pgsql's query privilege
Posted by GitBox <gi...@apache.org>.
KomachiSion merged pull request #5099: Check pgsql's query privilege
URL: https://github.com/apache/incubator-shardingsphere/pull/5099
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] ssxlulu commented on issue #5099: Check
pgsql's query privilege
Posted by GitBox <gi...@apache.org>.
ssxlulu commented on issue #5099: Check pgsql's query privilege
URL: https://github.com/apache/incubator-shardingsphere/pull/5099#issuecomment-611363717
> Any unit test for `PostgreSQLDataSourceChecker.java`?
A new pr will add the unit test of `PostgreSQLDataSourceChecker.java` and `MySQLDataSourceChecker`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #5099:
Check pgsql's query privilege
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #5099: Check pgsql's query privilege
URL: https://github.com/apache/incubator-shardingsphere/pull/5099#issuecomment-610748868
## Pull Request Test Coverage Report for [Build 10877](https://coveralls.io/builds/29928698)
* **0** of **11** **(0.0%)** changed or added relevant lines in **1** file are covered.
* **1** unchanged line in **1** file lost coverage.
* Overall coverage decreased (**-0.03%**) to **57.286%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [sharding-scaling/sharding-scaling-postgresql/src/main/java/org/apache/shardingsphere/shardingscaling/postgresql/PostgreSQLDataSourceChecker.java](https://coveralls.io/builds/29928698/source?filename=sharding-scaling%2Fsharding-scaling-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fpostgresql%2FPostgreSQLDataSourceChecker.java#L37) | 0 | 11 | 0.0%
<!-- | **Total:** | **0** | **11** | **0.0%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-scaling/sharding-scaling-postgresql/src/main/java/org/apache/shardingsphere/shardingscaling/postgresql/PostgreSQLDataSourceChecker.java](https://coveralls.io/builds/29928698/source?filename=sharding-scaling%2Fsharding-scaling-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fpostgresql%2FPostgreSQLDataSourceChecker.java#L51) | 1 | 0% |
<!-- | **Total:** | **1** | | -->
| Totals | [](https://coveralls.io/builds/29928698) |
| :-- | --: |
| Change from base [Build 10876](https://coveralls.io/builds/29928409): | -0.03% |
| Covered Lines: | 11668 |
| Relevant Lines: | 20368 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] ssxlulu edited a comment on issue #5099:
Check pgsql's query privilege
Posted by GitBox <gi...@apache.org>.
ssxlulu edited a comment on issue #5099: Check pgsql's query privilege
URL: https://github.com/apache/incubator-shardingsphere/pull/5099#issuecomment-611363717
> Any unit test for `PostgreSQLDataSourceChecker.java`?
A new pr will add the unit tests of `PostgreSQLDataSourceChecker.java` and `MySQLDataSourceChecker.java`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services