You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by jongyoul <gi...@git.apache.org> on 2016/07/05 03:53:28 UTC

[GitHub] zeppelin pull request #1128: [HOTFIX] NPE when there's no properties field i...

GitHub user jongyoul opened a pull request:

    https://github.com/apache/zeppelin/pull/1128

    [HOTFIX] NPE when there's no properties field in interpreter-setting.json

    ### What is this PR for?
    Fixing NPE while initializing interpreters from interpreter-setting.json
    
    
    ### What type of PR is it?
    [Bug Fix | Hot Fix]
    
    ### Todos
    * [x] - Fix NPE
    
    ### What is the Jira issue?
    N/A
    
    ### How should this be tested?
    1. delete `properties` in one of `interpreter-setting.json`
    1. Build and run
    1. Got error
    1. Apply this PR
    1. Build and run
    1. Run it successfully
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jongyoul/zeppelin hotfix/interpreter-properties-is-null

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1128.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1128
    
----
commit 0b89b3a166e5505f398ece73e7c83d77f2c982f3
Author: Jongyoul Lee <jl...@jongyouls-imac.local>
Date:   2016-07-05T03:49:22Z

    Fixed NPE when there's no properties field in interpreter-setting.json

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1128: [HOTFIX] NPE when there's no properties field in inter...

Posted by prabhjyotsingh <gi...@git.apache.org>.

Github user prabhjyotsingh commented on the issue:

    https://github.com/apache/zeppelin/pull/1128
  
    Good catch, agreed with @bzz, let's merge asap.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1128: [HOTFIX] NPE when there's no properties field in inter...

Posted by bzz <gi...@git.apache.org>.

Github user bzz commented on the issue:

    https://github.com/apache/zeppelin/pull/1128
  
    Looks good to me, let's merge asap as HOTFIX


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1128: [HOTFIX] NPE when there's no properties field i...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/1128


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1128: [HOTFIX] NPE when there's no properties field in inter...

Posted by khalidhuseynov <gi...@git.apache.org>.

Github user khalidhuseynov commented on the issue:

    https://github.com/apache/zeppelin/pull/1128
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---