You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@jclouds.apache.org by Xianguang Zhou <no...@github.com> on 2015/11/29 14:17:55 UTC

[jclouds] create OpenStack API by "Access" object or token (#886)

https://issues.apache.org/jira/browse/JCLOUDS-1040
https://issues.apache.org/jira/browse/JCLOUDS-1039
You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds/pull/886

-- Commit Summary --

  * create OpenStack API by "Access" object or token

-- File Changes --

    M apis/chef/src/test/resources/logback.xml (66)
    M apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/AuthenticationApi.java (6)
    M apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/config/CredentialTypes.java (2)
    M apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/domain/Access.java (3)
    M apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/domain/Endpoint.java (3)
    M apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/domain/Role.java (3)
    M apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/domain/Service.java (3)
    M apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/domain/Tenant.java (3)
    M apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/domain/Token.java (3)
    A apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/domain/TokenId.java (116)
    M apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/domain/User.java (3)
    M apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/functions/AuthenticatePasswordCredentials.java (6)
    M apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/functions/internal/BaseAuthenticator.java (77)
    M apis/openstack-keystone/src/test/resources/logback.xml (128)
    M apis/rackspace-clouddns/src/test/resources/logback.xml (76)
    M apis/route53/src/test/resources/logback.xml (76)
    M compute/src/test/resources/logback.xml (128)
    M core/src/main/java/org/jclouds/ContextBuilder.java (24)
    M core/src/main/java/org/jclouds/domain/Credentials.java (64)
    M core/src/main/java/org/jclouds/domain/LoginCredentials.java (31)
    M providers/dynect/src/test/resources/logback.xml (76)
    M providers/ultradns-ws/src/test/resources/logback.xml (76)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/886.patch
https://github.com/jclouds/jclouds/pull/886.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/886

Re: [jclouds/jclouds] create OpenStack API by "Access" object or token (#886)

Posted by Xianguang Zhou <no...@github.com>.

Closed #886.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/886#event-1262163608

Re: [jclouds] create OpenStack API by "Access" object or token (#886)

Posted by Ignasi Barrera <no...@github.com>.

Thanks for your contribution @Xianguang-Zhou! There several things that have to be addressed before we can review the PR in detail:

* First of all, remove all the unrelated changes: those `logback.xml` changed files and all the `Serializable` additions to all entities in the domain model. I don't think they are in the scope of this issue, so please, remove those changes from the PR.
* This change couples `jclouds-core` to very specific authentication details of a single provider, and we can't do that. The changes in core should be removed. (Could you also explain what that `accessReceiver` function is for?)
* Instead of reusing the `AuthenticatePasswordCredentials` to authenticate with the token, you should create a class that handles your new credential typeand register it [here](https://github.com/jclouds/jclouds/blob/master/apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/config/KeystoneAuthenticationModule.java#L218-L223).
* There are 33 unit tests failing (see the PR build details). All tests must be passing.

Once these points have been addressed we'll be able to do a detailed review. If you need help or guidance, please, comment here or find us in the jclouds dev@ mailing list or the #jclouds Freenode IRC channel. Thx!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/886#issuecomment-160573955

Re: [jclouds/jclouds] create OpenStack API by "Access" object or token (#886)

Posted by Xianguang Zhou <no...@github.com>.

I have used other OpenStack client library, I don't need the pull request any more, thank you.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/886#issuecomment-331594179

Re: [jclouds/jclouds] create OpenStack API by "Access" object or token (#886)

Posted by Andrew Gaul <no...@github.com>.

@Xianguang-Zhou do we have a path forward on this pull request?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/886#issuecomment-331355022