You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ant.apache.org by bu...@apache.org on 2012/10/03 17:12:18 UTC
[Bug 53959] New: delete task w/ removeNotFollowedSymlinks="true" and
includes,followSymLinks="false" on fileset does not filter symlinks correctly
https://issues.apache.org/bugzilla/show_bug.cgi?id=53959
Priority: P2
Bug ID: 53959
Assignee: notifications@ant.apache.org
Summary: delete task w/ removeNotFollowedSymlinks="true" and
includes,followSymLinks="false" on fileset does not
filter symlinks correctly
Severity: normal
Classification: Unclassified
OS: Linux
Reporter: jrojas@redlinesolutions.co
Hardware: PC
Status: NEW
Version: 1.8.4
Component: Core
Product: Ant
For example:
<delete removeNotFollowedSymlinks="true">
<fileset dir="someDir/" followSymlinks="false" includes="**/*.todelete" />
</delete>
This should only delete files with .todelete as the final extension, and remove
symlinks with .todelete as the extension as well.
However ANT removes ALL symlinks instead without filtering based on the
includes attribute.
The culprit is line 1229 in org.apache.tools.ant.DirectoryScanner. The line
should be:
if (isIncluded(name) && !isExcluded(name)) {
So that the included patterns are checked for symlinks.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 53959] delete task w/ removeNotFollowedSymlinks="true" and
includes,followSymLinks="false" on fileset does not filter symlinks correctly
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53959
Antoine Levy-Lambert <an...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Version|1.8.4 |1.9.0
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 53959] delete task w/ removeNotFollowedSymlinks="true" and
includes,followSymLinks="false" on fileset does not filter symlinks correctly
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53959
Stefan Bodewig <bo...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
Target Milestone|--- |1.9.4
--- Comment #1 from Stefan Bodewig <bo...@apache.org> ---
for directories somwhere along the path this is exactly what is wanted and lead
to the attribute.
With svn revision 1555490 symlinks to files will only get removed if the files
were included, this should fix the issue for you. For directories I've
tightened the logic slightly as well, but it likely won't make any difference
in practice.
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 53959] delete task w/ removeNotFollowedSymlinks="true" and
includes,followSymLinks="false" on fileset does not filter symlinks correctly
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53959
Antoine Levy-Lambert <an...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Version|1.9.0 |1.9.1
--
You are receiving this mail because:
You are the assignee for the bug.