You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2015/06/19 01:01:43 UTC
Review Request 35631: Added a performance benchmark for hierarchical
allocator addSlave.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35631/
-----------------------------------------------------------
Review request for mesos, Ben Mahler and Vinod Kone.
Bugs: MESOS-2892
https://issues.apache.org/jira/browse/MESOS-2892
Repository: mesos
Description
-------
Added a performance benchmark for hierarchical allocator addSlave.
Diffs
-----
src/tests/hierarchical_allocator_tests.cpp 85bb29e7cfc00579ff8f6d62d6c75e1b99ffcdba
Diff: https://reviews.apache.org/r/35631/diff/
Testing
-------
bin/mesos-test.sh --benchmark
Thanks,
Jie Yu
Re: Review Request 35631: Added a performance benchmark for
hierarchical allocator addSlave.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35631/#review88478
-----------------------------------------------------------
Ship it!
src/tests/hierarchical_allocator_tests.cpp (line 984)
<https://reviews.apache.org/r/35631/#comment141036>
Maybe a 1000 and 50,000 as well?
src/tests/hierarchical_allocator_tests.cpp (lines 991 - 993)
<https://reviews.apache.org/r/35631/#comment141034>
Doesn't this need to be an atomic?
- Ben Mahler
On June 19, 2015, 1:11 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35631/
> -----------------------------------------------------------
>
> (Updated June 19, 2015, 1:11 a.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-2892
> https://issues.apache.org/jira/browse/MESOS-2892
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a performance benchmark for hierarchical allocator addSlave.
>
>
> Diffs
> -----
>
> src/tests/hierarchical_allocator_tests.cpp 85bb29e7cfc00579ff8f6d62d6c75e1b99ffcdba
> src/tests/registrar_tests.cpp ebcce73b627b3cee044bf239c4d3ba9753a8fa73
>
> Diff: https://reviews.apache.org/r/35631/diff/
>
>
> Testing
> -------
>
> bin/mesos-test.sh --benchmark
>
> 0.23.0 current master
>
>
> 0.23.0 before MESOS-2373
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 35631: Added a performance benchmark for
hierarchical allocator addSlave.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35631/
-----------------------------------------------------------
(Updated June 19, 2015, 1:11 a.m.)
Review request for mesos, Ben Mahler and Vinod Kone.
Changes
-------
Review comments.
Bugs: MESOS-2892
https://issues.apache.org/jira/browse/MESOS-2892
Repository: mesos
Description
-------
Added a performance benchmark for hierarchical allocator addSlave.
Diffs (updated)
-----
src/tests/hierarchical_allocator_tests.cpp 85bb29e7cfc00579ff8f6d62d6c75e1b99ffcdba
src/tests/registrar_tests.cpp ebcce73b627b3cee044bf239c4d3ba9753a8fa73
Diff: https://reviews.apache.org/r/35631/diff/
Testing
-------
bin/mesos-test.sh --benchmark
0.23.0 current master
0.23.0 before MESOS-2373
Thanks,
Jie Yu
Re: Review Request 35631: Added a performance benchmark for
hierarchical allocator addSlave.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35631/#review88472
-----------------------------------------------------------
Ship it!
Great, thanks Jie!
src/tests/hierarchical_allocator_tests.cpp (line 976)
<https://reviews.apache.org/r/35631/#comment141009>
I think we were avoiding {} here before we had gcc 4.8 as an assumption, so should be safe to do now, up to you.
src/tests/hierarchical_allocator_tests.cpp (line 980)
<https://reviews.apache.org/r/35631/#comment141008>
Can you do {} instead of explicit hashmap construction?
src/tests/hierarchical_allocator_tests.cpp (line 986)
<https://reviews.apache.org/r/35631/#comment141010>
Maybe just s/slaveCount/GetParam()/ and remove the 'slaveCount' variable? Then below you could replace 'slaveCount' with 'slaves.size()' or a foreach loop. Whichever you think is cleaner!
src/tests/hierarchical_allocator_tests.cpp (line 994)
<https://reviews.apache.org/r/35631/#comment141007>
Might be nice to have a bit more port fragmentation, to match the pathological scenario. :)
- Ben Mahler
On June 19, 2015, 12:15 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35631/
> -----------------------------------------------------------
>
> (Updated June 19, 2015, 12:15 a.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-2892
> https://issues.apache.org/jira/browse/MESOS-2892
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a performance benchmark for hierarchical allocator addSlave.
>
>
> Diffs
> -----
>
> src/tests/hierarchical_allocator_tests.cpp 85bb29e7cfc00579ff8f6d62d6c75e1b99ffcdba
>
> Diff: https://reviews.apache.org/r/35631/diff/
>
>
> Testing
> -------
>
> bin/mesos-test.sh --benchmark
>
> 0.23.0 current master
>
>
> 0.23.0 before MESOS-2373
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 35631: Added a performance benchmark for
hierarchical allocator addSlave.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35631/
-----------------------------------------------------------
(Updated June 19, 2015, 12:15 a.m.)
Review request for mesos, Ben Mahler and Vinod Kone.
Bugs: MESOS-2892
https://issues.apache.org/jira/browse/MESOS-2892
Repository: mesos
Description
-------
Added a performance benchmark for hierarchical allocator addSlave.
Diffs
-----
src/tests/hierarchical_allocator_tests.cpp 85bb29e7cfc00579ff8f6d62d6c75e1b99ffcdba
Diff: https://reviews.apache.org/r/35631/diff/
Testing (updated)
-------
bin/mesos-test.sh --benchmark
0.23.0 current master
0.23.0 before MESOS-2373
Thanks,
Jie Yu
Re: Review Request 35631: Added a performance benchmark for
hierarchical allocator addSlave.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35631/
-----------------------------------------------------------
(Updated June 19, 2015, 12:15 a.m.)
Review request for mesos, Ben Mahler and Vinod Kone.
Changes
-------
Updated.
Bugs: MESOS-2892
https://issues.apache.org/jira/browse/MESOS-2892
Repository: mesos
Description
-------
Added a performance benchmark for hierarchical allocator addSlave.
Diffs (updated)
-----
src/tests/hierarchical_allocator_tests.cpp 85bb29e7cfc00579ff8f6d62d6c75e1b99ffcdba
Diff: https://reviews.apache.org/r/35631/diff/
Testing
-------
bin/mesos-test.sh --benchmark
0.23.0 current master
[==========] Running 4 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 4 tests from SlaveCount/HierarchicalAllocator_BENCHMARK_Test
[ RUN ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.AddSlave/0
[ OK ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.AddSlave/0 (2539 ms)
[ RUN ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.AddSlave/1
[ OK ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.AddSlave/1 (5120 ms)
[ RUN ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.AddSlave/2
[ OK ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.AddSlave/2 (7534 ms)
[ RUN ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.AddSlave/3
[ OK ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.AddSlave/3 (12663 ms)
[----------] 4 tests from SlaveCount/HierarchicalAllocator_BENCHMARK_Test (27856 ms total)
[----------] Global test environment tear-down
[==========] 4 tests from 1 test case ran. (27900 ms total)
[ PASSED ] 4 tests.
0.23.0 before MESOS-2373
[==========] Running 4 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 4 tests from SlaveCount/HierarchicalAllocator_BENCHMARK_Test
[ RUN ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.AddSlave/0
[ OK ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.AddSlave/0 (1786 ms)
[ RUN ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.AddSlave/1
[ OK ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.AddSlave/1 (3638 ms)
[ RUN ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.AddSlave/2
[ OK ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.AddSlave/2 (5319 ms)
[ RUN ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.AddSlave/3
[ OK ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.AddSlave/3 (8949 ms)
[----------] 4 tests from SlaveCount/HierarchicalAllocator_BENCHMARK_Test (19693 ms total)
[----------] Global test environment tear-down
[==========] 4 tests from 1 test case ran. (19735 ms total)
[ PASSED ] 4 tests.
Thanks,
Jie Yu
Re: Review Request 35631: Added a performance benchmark for
hierarchical allocator addSlave.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35631/
-----------------------------------------------------------
(Updated June 18, 2015, 11:14 p.m.)
Review request for mesos, Ben Mahler and Vinod Kone.
Bugs: MESOS-2892
https://issues.apache.org/jira/browse/MESOS-2892
Repository: mesos
Description
-------
Added a performance benchmark for hierarchical allocator addSlave.
Diffs
-----
src/tests/hierarchical_allocator_tests.cpp 85bb29e7cfc00579ff8f6d62d6c75e1b99ffcdba
Diff: https://reviews.apache.org/r/35631/diff/
Testing (updated)
-------
bin/mesos-test.sh --benchmark
0.23.0 current master
[==========] Running 4 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 4 tests from SlaveCount/HierarchicalAllocator_BENCHMARK_Test
[ RUN ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.AddSlave/0
[ OK ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.AddSlave/0 (2539 ms)
[ RUN ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.AddSlave/1
[ OK ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.AddSlave/1 (5120 ms)
[ RUN ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.AddSlave/2
[ OK ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.AddSlave/2 (7534 ms)
[ RUN ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.AddSlave/3
[ OK ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.AddSlave/3 (12663 ms)
[----------] 4 tests from SlaveCount/HierarchicalAllocator_BENCHMARK_Test (27856 ms total)
[----------] Global test environment tear-down
[==========] 4 tests from 1 test case ran. (27900 ms total)
[ PASSED ] 4 tests.
0.23.0 before MESOS-2373
[==========] Running 4 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 4 tests from SlaveCount/HierarchicalAllocator_BENCHMARK_Test
[ RUN ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.AddSlave/0
[ OK ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.AddSlave/0 (1786 ms)
[ RUN ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.AddSlave/1
[ OK ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.AddSlave/1 (3638 ms)
[ RUN ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.AddSlave/2
[ OK ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.AddSlave/2 (5319 ms)
[ RUN ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.AddSlave/3
[ OK ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.AddSlave/3 (8949 ms)
[----------] 4 tests from SlaveCount/HierarchicalAllocator_BENCHMARK_Test (19693 ms total)
[----------] Global test environment tear-down
[==========] 4 tests from 1 test case ran. (19735 ms total)
[ PASSED ] 4 tests.
Thanks,
Jie Yu
Re: Review Request 35631: Added a performance benchmark for
hierarchical allocator addSlave.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35631/
-----------------------------------------------------------
(Updated June 18, 2015, 11:12 p.m.)
Review request for mesos, Ben Mahler and Vinod Kone.
Bugs: MESOS-2892
https://issues.apache.org/jira/browse/MESOS-2892
Repository: mesos
Description
-------
Added a performance benchmark for hierarchical allocator addSlave.
Diffs
-----
src/tests/hierarchical_allocator_tests.cpp 85bb29e7cfc00579ff8f6d62d6c75e1b99ffcdba
Diff: https://reviews.apache.org/r/35631/diff/
Testing (updated)
-------
bin/mesos-test.sh --benchmark
0.23.0 current master
[==========] Running 4 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 4 tests from SlaveCount/HierarchicalAllocator_BENCHMARK_Test
[ RUN ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.AddSlave/0
[ OK ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.AddSlave/0 (2539 ms)
[ RUN ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.AddSlave/1
[ OK ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.AddSlave/1 (5120 ms)
[ RUN ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.AddSlave/2
[ OK ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.AddSlave/2 (7534 ms)
[ RUN ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.AddSlave/3
[ OK ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.AddSlave/3 (12663 ms)
[----------] 4 tests from SlaveCount/HierarchicalAllocator_BENCHMARK_Test (27856 ms total)
[----------] Global test environment tear-down
[==========] 4 tests from 1 test case ran. (27900 ms total)
[ PASSED ] 4 tests.
0.23.0 before MESOS-2373
1.
2.[==========] Running 4 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 4 tests from SlaveCount/HierarchicalAllocator_BENCHMARK_Test
[ RUN ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.AddSlave/0
[ OK ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.AddSlave/0 (1786 ms)
[ RUN ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.AddSlave/1
[ OK ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.AddSlave/1 (3638 ms)
[ RUN ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.AddSlave/2
[ OK ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.AddSlave/2 (5319 ms)
[ RUN ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.AddSlave/3
[ OK ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.AddSlave/3 (8949 ms)
[----------] 4 tests from SlaveCount/HierarchicalAllocator_BENCHMARK_Test (19693 ms total)
[----------] Global test environment tear-down
[==========] 4 tests from 1 test case ran. (19735 ms total)
[ PASSED ] 4 tests.
Thanks,
Jie Yu
Re: Review Request 35631: Added a performance benchmark for
hierarchical allocator addSlave.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35631/
-----------------------------------------------------------
(Updated June 18, 2015, 11:02 p.m.)
Review request for mesos, Ben Mahler and Vinod Kone.
Bugs: MESOS-2892
https://issues.apache.org/jira/browse/MESOS-2892
Repository: mesos
Description
-------
Added a performance benchmark for hierarchical allocator addSlave.
Diffs
-----
src/tests/hierarchical_allocator_tests.cpp 85bb29e7cfc00579ff8f6d62d6c75e1b99ffcdba
Diff: https://reviews.apache.org/r/35631/diff/
Testing (updated)
-------
bin/mesos-test.sh --benchmark
0.23.0 current master
[==========] Running 4 tests from 1 test case.
[----------] Global test environment set-up.
[----------] 4 tests from SlaveCount/HierarchicalAllocator_BENCHMARK_Test
[ RUN ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.AddSlave/0
[ OK ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.AddSlave/0 (2539 ms)
[ RUN ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.AddSlave/1
[ OK ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.AddSlave/1 (5120 ms)
[ RUN ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.AddSlave/2
[ OK ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.AddSlave/2 (7534 ms)
[ RUN ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.AddSlave/3
[ OK ] SlaveCount/HierarchicalAllocator_BENCHMARK_Test.AddSlave/3 (12663 ms)
[----------] 4 tests from SlaveCount/HierarchicalAllocator_BENCHMARK_Test (27856 ms total)
[----------] Global test environment tear-down
[==========] 4 tests from 1 test case ran. (27900 ms total)
[ PASSED ] 4 tests.
Thanks,
Jie Yu