You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/11/02 14:39:44 UTC
[GitHub] [beam] alexeyinkin opened a new pull request, #23941: Gradle tasks to start playground locally (#23939)
alexeyinkin opened a new pull request, #23941:
URL: https://github.com/apache/beam/pull/23941
- Resolves #23939
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damondouglas commented on a diff in pull request #23941: Gradle tasks to start playground locally (#23939)
Posted by GitBox <gi...@apache.org>.
damondouglas commented on code in PR #23941:
URL: https://github.com/apache/beam/pull/23941#discussion_r1046023992
##########
playground/README.md:
##########
@@ -62,19 +62,47 @@ cd beam
## Run local environment using docker compose
-```
+### Router only
+
+Start:
+
+```bash
cd beam
./gradlew playground:backend:containers:router:dockerComposeLocalUp
Review Comment:
Now that we are migrating to kubernetes, may we consider moving away from docker compose? An alternative is minikube. If you'd like a pair programming session to set this up, I'm more than willing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] alexeyinkin commented on pull request #23941: Gradle tasks to start playground locally (#23939)
Posted by GitBox <gi...@apache.org>.
alexeyinkin commented on PR #23941:
URL: https://github.com/apache/beam/pull/23941#issuecomment-1344304346
R: @damondouglas
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem merged pull request #23941: Gradle tasks to start playground locally (#23939)
Posted by GitBox <gi...@apache.org>.
pabloem merged PR #23941:
URL: https://github.com/apache/beam/pull/23941
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] alexeyinkin commented on a diff in pull request #23941: Gradle tasks to start playground locally (#23939)
Posted by GitBox <gi...@apache.org>.
alexeyinkin commented on code in PR #23941:
URL: https://github.com/apache/beam/pull/23941#discussion_r1046084350
##########
playground/README.md:
##########
@@ -62,19 +62,47 @@ cd beam
## Run local environment using docker compose
-```
+### Router only
+
+Start:
+
+```bash
cd beam
./gradlew playground:backend:containers:router:dockerComposeLocalUp
Review Comment:
I have never been using Kubernetes in any way so it would take days to prepare for that session. Although I am too more than willing.
There may be benefits of minikube over local Docker, but this branch is more of a daily tool to us to develop against an undeployed backend. And the frontend does not care how the backend is started as long as it has a host and a port. We currently copy this configuration from one local branch to another. So it would just save time today if we had it in master.
One other reason to keep docker compose for awhile is that we already have it elsewhere, for instance in https://github.com/apache/beam/blob/master/playground/backend/containers/router/docker-compose.local.yml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23941: Gradle tasks to start playground locally (#23939)
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23941:
URL: https://github.com/apache/beam/pull/23941#issuecomment-1344305505
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #23941: Gradle tasks to start playground locally (#23939)
Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #23941:
URL: https://github.com/apache/beam/pull/23941#issuecomment-1352618516
lgtm thanks y'all
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] vchunikhin commented on pull request #23941: Gradle tasks to start playground locally (#23939)
Posted by GitBox <gi...@apache.org>.
vchunikhin commented on PR #23941:
URL: https://github.com/apache/beam/pull/23941#issuecomment-1301766461
lgtm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org