IntelliJ IDEA specs failing

[Alex Boisvert <al...@gmail.com>]

Hi Peter,

Running the IDEA specs today, I'm getting:

  1) Buildr::IntellijIdea Buildr::IntellijIdea::IdeaModule with
local_repository_env_override = nil base_directory on different drive on
windows generates relative paths correctly
     Failure/Error: @foo.iml.send(:resolve_path, "E:/foo").should
eql('E:/foo')

     expected "E:/foo"
          got "$MODULE_DIR$/../../E:/foo"

     (compared using eql?)
     # ./spec/ide/idea_spec.rb:1030

Is this something you can reproduce?

alex


On Sun, Jan 30, 2011 at 4:40 PM, Peter Donald <pe...@realityforge.org>wrote:

> Hi,
>
> I tested it out on all our builds and only found one issue. JIRA is
> down for system maintenance right nowso I have attached a patch to
> address this but am away from the computer with the key to access svn
> atm. So if you could make sure this change gets in before release I am
> +1 for a release. The message for the commit should be something like
>
> ------------------------------------
> Ensure that the IDEA module is generated correctly when the module
> contains no java files.
>
> Without this change the output directory would be the project root
> which would end up being excluded as a result. This problem was caused
> by the refactor of the plugin prior to migrating it into buildr core.
> ------------------------------------
>
> On Fri, Jan 28, 2011 at 4:54 PM, Alex Boisvert <al...@gmail.com>
> wrote:
> > I'm thinking about releasing Buildr 1.4.5 towards end of next week.  I
> want
> > to keep pushing regular releases out and I think we have a fair number of
> > issues/changes that would benefit our users.
> >
> > If you want to get anything else in this release or feel the timing isn't
> > right, please shout.
>
> --
> Cheers,
>
> Peter Donald
>

Re: IntelliJ IDEA specs failing

[Peter Donald <pe...@realityforge.org>]

>  1) Buildr::IntellijIdea Buildr::IntellijIdea::IdeaModule with
> local_repository_env_override = nil base_directory on different drive on
> windows generates relative paths correctly
>     Failure/Error: @foo.iml.send(:resolve_path, "E:/foo").should
> eql('E:/foo')
>
>     expected "E:/foo"
>          got "$MODULE_DIR$/../../E:/foo"
>
>     (compared using eql?)
>     # ./spec/ide/idea_spec.rb:1030
>
> Is this something you can reproduce?

All of my testing has been done with jruby 1.5.2 or 1.5.6.RC1 on
windows 7 atm and I don't have access to a *nix box. I suspect it is
probably a difference between how the path is handled on *nix or
perhaps on the MRI. You could possible guard the spec with an "if
Buildr::Util.win_os?" if that is the case.

-- 
Cheers,

Peter Donald