You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/24 03:51:47 UTC
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #31946: [SPARK-34846][SQL][TEST] Sort output rows in SQLQueryTestSuite even if a plan has a Sort node
dongjoon-hyun commented on a change in pull request #31946:
URL: https://github.com/apache/spark/pull/31946#discussion_r600143217
##########
File path: sql/core/src/test/resources/sql-tests/results/group-analytics.sql.out
##########
@@ -101,29 +101,29 @@ SELECT course, year, SUM(earnings) FROM courseSales GROUP BY ROLLUP(course, year
-- !query schema
struct<course:string,year:int,sum(earnings):bigint>
-- !query output
-NULL NULL 113000
-Java NULL 50000
Java 2012 20000
Java 2013 30000
-dotNET NULL 63000
+Java NULL 50000
+NULL NULL 113000
dotNET 2012 15000
dotNET 2013 48000
+dotNET NULL 63000
-- !query
SELECT course, year, SUM(earnings) FROM courseSales GROUP BY CUBE(course, year) ORDER BY course, year
-- !query schema
struct<course:string,year:int,sum(earnings):bigint>
-- !query output
-NULL NULL 113000
-NULL 2012 35000
-NULL 2013 78000
-Java NULL 50000
Java 2012 20000
Java 2013 30000
-dotNET NULL 63000
+Java NULL 50000
+NULL 2012 35000
Review comment:
Well, are we sorting `NULL` as a string? This looks like hiding another kind of bugs, e.g., Sorting with NULL first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org