[jira] [Comment Edited] (IGNITE-9178) Partition lost event are not triggered if multiple nodes left cluster

["Alexey Goncharuk (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IGNITE-9178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16576140#comment-16576140 ] 

Alexey Goncharuk edited comment on IGNITE-9178 at 8/10/18 11:35 AM:
--------------------------------------------------------------------

[~pvinokurov] Can you please explain why you needed to update {{leftNode2Part}} inside the loop and how this fixes the missed event? 

Note that there is a separate method handling left nodes - {{removeNode()}}, and from the current code I see that not only does it add new entry to {{leftNode2Part}}, but it also updates {{diffFromAffinity}} map. With your change it looks like the {{diffFromAffinity}} map may be outdated. I see that {{removeNode()}} is called in {{beforeExchange}} for all left nodes, so I it is not clear why those nodes did not get to {{leftNode2Part}}


was (Author: agoncharuk):
[~pvinokurov] Can you please explain why you needed to update {{leftNode2Part}} inside the loop and how this fixes the missed event? 

Note that there is a separate method handling left nodes - {{removeNode()}}, and from the current code I see that not only does it add new entry to {{leftNode2Part}}, but it also updates {{diffFromAffinity}} map. With your change it looks like the {{diffFromAffinity}} map may be outdated.

> Partition lost event are not triggered if multiple nodes left cluster
> ---------------------------------------------------------------------
>
>                 Key: IGNITE-9178
>                 URL: https://issues.apache.org/jira/browse/IGNITE-9178
>             Project: Ignite
>          Issue Type: Bug
>          Components: cache
>    Affects Versions: 2.4
>            Reporter: Pavel Vinokurov
>            Assignee: Pavel Vinokurov
>            Priority: Blocker
>             Fix For: 2.7
>
>
> If multiple nodes left cluster simultaneously, left partitions are removed from GridDhtPartitionTopologyImpl#node2part without adding to leftNode2Part  in GridDhtPartitionTopologyImpl#update method.
> Thus GridDhtPartitionTopologyImpl#detectLostPartitions can't detect lost partitions



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)