[GitHub] [incubator-superset] rusackas commented on issue #8606: Using Prettier for CSS

[GitBox <gi...@apache.org>]

rusackas commented on issue #8606: Using Prettier for CSS
URL: https://github.com/apache/incubator-superset/pull/8606#issuecomment-555849475
 
 
   > Happy to merge this as-is, but do we want to break the build if there's lint in the CSS?
   > 
   > I think to do so we'd have to add a trailing command to the npm run lint.
   > 
   > Oh what about adding a commit hook as well?
   
   @mistercrunch I believe (if I did this right) that nothing should break. There's actually no linting enforcement for CSS. If you run `lint-fix` it will run Prettier and auto-format the CSS, but the `lint` command doesn't do anything with prettier. So nothing should break, but there's an easy means to clean stuff up. 
   
   In parallel, I'm slowly starting rules for Stylelint to make issues more apparent in IDEs. Once the rules gel a little bit, we can consider adding lint enforcement of CSS to the build process.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org