You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gastón Kleiman <ga...@mesosphere.io> on 2017/03/15 14:58:10 UTC
Review Request 57644: Implemented
'ComposingContainerizer::remove(const ContainerID&)'.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57644/
-----------------------------------------------------------
Review request for mesos, Alexander Rukletsov and Vinod Kone.
Bugs: MESOS-7248
https://issues.apache.org/jira/browse/MESOS-7248
Repository: mesos
Description
-------
See the summary.
Diffs
-----
src/slave/containerizer/composing.hpp 292374aefbc70e4b9d8c81740656864dbada8e32
src/slave/containerizer/composing.cpp 46539e4671101f9c51de563f52700e974537b472
Diff: https://reviews.apache.org/r/57644/diff/1/
Testing
-------
`make check` in Linux + manual testing
Thanks,
Gast�n Kleiman
Re: Review Request 57644: Implemented
'ComposingContainerizer::remove(const ContainerID&)'.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57644/#review169053
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rukletsov
On March 15, 2017, 4:54 p.m., Gast�n Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57644/
> -----------------------------------------------------------
>
> (Updated March 15, 2017, 4:54 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Vinod Kone.
>
>
> Bugs: MESOS-7248
> https://issues.apache.org/jira/browse/MESOS-7248
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented 'ComposingContainerizer::remove(const ContainerID&)'.
>
>
> Diffs
> -----
>
> src/slave/containerizer/composing.hpp 292374aefbc70e4b9d8c81740656864dbada8e32
> src/slave/containerizer/composing.cpp 46539e4671101f9c51de563f52700e974537b472
>
>
> Diff: https://reviews.apache.org/r/57644/diff/3/
>
>
> Testing
> -------
>
> `make check` in Linux + manual testing
>
>
> Thanks,
>
> Gast�n Kleiman
>
>
Re: Review Request 57644: Implemented
'ComposingContainerizer::remove(const ContainerID&)'.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57644/
-----------------------------------------------------------
(Updated March 15, 2017, 4:54 p.m.)
Review request for mesos, Alexander Rukletsov and Vinod Kone.
Changes
-------
Added a comment and made the failure message locally consistent.
Bugs: MESOS-7248
https://issues.apache.org/jira/browse/MESOS-7248
Repository: mesos
Description
-------
Implemented 'ComposingContainerizer::remove(const ContainerID&)'.
Diffs (updated)
-----
src/slave/containerizer/composing.hpp 292374aefbc70e4b9d8c81740656864dbada8e32
src/slave/containerizer/composing.cpp 46539e4671101f9c51de563f52700e974537b472
Diff: https://reviews.apache.org/r/57644/diff/3/
Changes: https://reviews.apache.org/r/57644/diff/2-3/
Testing
-------
`make check` in Linux + manual testing
Thanks,
Gast�n Kleiman
Re: Review Request 57644: Implemented
'ComposingContainerizer::remove(const ContainerID&)'.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57644/#review169026
-----------------------------------------------------------
src/slave/containerizer/composing.cpp
Lines 499-502 (original), 507-510 (patched)
<https://reviews.apache.org/r/57644/#comment241354>
Could you please make failure messages consistent? Probably in the next RR.
- Alexander Rukletsov
On March 15, 2017, 4:18 p.m., Gast�n Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57644/
> -----------------------------------------------------------
>
> (Updated March 15, 2017, 4:18 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Vinod Kone.
>
>
> Bugs: MESOS-7248
> https://issues.apache.org/jira/browse/MESOS-7248
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented 'ComposingContainerizer::remove(const ContainerID&)'.
>
>
> Diffs
> -----
>
> src/slave/containerizer/composing.hpp 292374aefbc70e4b9d8c81740656864dbada8e32
> src/slave/containerizer/composing.cpp 46539e4671101f9c51de563f52700e974537b472
>
>
> Diff: https://reviews.apache.org/r/57644/diff/2/
>
>
> Testing
> -------
>
> `make check` in Linux + manual testing
>
>
> Thanks,
>
> Gast�n Kleiman
>
>
Re: Review Request 57644: Implemented
'ComposingContainerizer::remove(const ContainerID&)'.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57644/
-----------------------------------------------------------
(Updated March 15, 2017, 4:18 p.m.)
Review request for mesos, Alexander Rukletsov and Vinod Kone.
Changes
-------
Vinod's comment.
Bugs: MESOS-7248
https://issues.apache.org/jira/browse/MESOS-7248
Repository: mesos
Description (updated)
-------
Implemented 'ComposingContainerizer::remove(const ContainerID&)'.
Diffs (updated)
-----
src/slave/containerizer/composing.hpp 292374aefbc70e4b9d8c81740656864dbada8e32
src/slave/containerizer/composing.cpp 46539e4671101f9c51de563f52700e974537b472
Diff: https://reviews.apache.org/r/57644/diff/2/
Changes: https://reviews.apache.org/r/57644/diff/1-2/
Testing
-------
`make check` in Linux + manual testing
Thanks,
Gast�n Kleiman
Re: Review Request 57644: Implemented
'ComposingContainerizer::remove(const ContainerID&)'.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57644/#review169023
-----------------------------------------------------------
Fix it, then Ship it!
src/slave/containerizer/composing.cpp
Lines 714 (patched)
<https://reviews.apache.org/r/57644/#comment241353>
s/Parent/Root/
- Vinod Kone
On March 15, 2017, 2:58 p.m., Gast�n Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57644/
> -----------------------------------------------------------
>
> (Updated March 15, 2017, 2:58 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Vinod Kone.
>
>
> Bugs: MESOS-7248
> https://issues.apache.org/jira/browse/MESOS-7248
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See the summary.
>
>
> Diffs
> -----
>
> src/slave/containerizer/composing.hpp 292374aefbc70e4b9d8c81740656864dbada8e32
> src/slave/containerizer/composing.cpp 46539e4671101f9c51de563f52700e974537b472
>
>
> Diff: https://reviews.apache.org/r/57644/diff/1/
>
>
> Testing
> -------
>
> `make check` in Linux + manual testing
>
>
> Thanks,
>
> Gast�n Kleiman
>
>