You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2015/05/28 22:58:49 UTC

[Bug 57969] New: @PathParam annotation captures incorrect value under high load

https://bz.apache.org/bugzilla/show_bug.cgi?id=57969

            Bug ID: 57969
           Summary: @PathParam annotation captures incorrect value under
                    high load
           Product: Tomcat 7
           Version: 7.0.59
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: major
          Priority: P2
         Component: WebSocket
          Assignee: dev@tomcat.apache.org
          Reporter: peter_kovac11@hotmail.com

Under high load, given a @ServerEndpoint like


@ServerEndpoint(value="/websocket/{key}", configurator=MyConfigurator.class)
public class ExecutionMonitoringEndpoint{
...
@OnMessage
public void onMessage(@PathParam("key") String key, String payload) {
   ...
}
}
//where MyConfigurator is used to only inject a custom property like
ServerEndpointConfig.conf.getUserProperties().put(...);

we noticed that the captured PathParam ("key" in this case) was sometimes mixed
up with another concurrent request - causing double subscriptions in our
pub/sub application.


Changing the above to

@ServerEndpoint(value="/websocket/{key}", configurator=MyConfigurator.class)
public class ExecutionMonitoringEndpoint{
...
@OnMessage
public void onMessage(Session session, String payload) {
  String key = session.getPathParameters().get("key");
}
}

fixed the problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 57969] @PathParam annotation captures incorrect value under high load

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=57969

Violeta Georgieva <vi...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ktmnealio@gmail.com

--- Comment #3 from Violeta Georgieva <vi...@apache.org> ---
*** Bug 58059 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 57969] @PathParam annotation captures incorrect value under high load

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=57969

Violeta Georgieva <vi...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Violeta Georgieva <vi...@apache.org> ---
Hi,

This is fixed in trunk, in 8.0.x for 8.0.24 and in 7.0.x for 7.0.63 onwards.

Regards,
Violeta

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


[Bug 57969] @PathParam annotation captures incorrect value under high load

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=57969

--- Comment #1 from Violeta Georgieva <vi...@apache.org> ---
Created attachment 32794
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=32794&action=edit
Patch proposal

Hi,

I succeeded to reproduce the issue.
I'm attaching a patch proposal.

Regards,
Violeta

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org