[GitHub] [hudi] danny0405 commented on a change in pull request #3317: [HUDI-2203] When the orderingVal is the same, take the latest one

[GitBox <gi...@apache.org>]

danny0405 commented on a change in pull request #3317:
URL: https://github.com/apache/hudi/pull/3317#discussion_r673824944



##########
File path: hudi-common/src/main/java/org/apache/hudi/common/model/OverwriteWithLatestAvroPayload.java
##########
@@ -49,7 +49,7 @@ public OverwriteWithLatestAvroPayload(Option<GenericRecord> record) {
   @Override
   public OverwriteWithLatestAvroPayload preCombine(OverwriteWithLatestAvroPayload another) {
     // pick the payload with greatest ordering value
-    if (another.orderingVal.compareTo(orderingVal) > 0) {
+    if (another.orderingVal.compareTo(orderingVal) >= 0) {
       return another;

Review comment:
       The original logic is actually right, because the passed in `another` is the old existing value.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org