You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by "Rob Lugt (JIRA)" <ji...@apache.org> on 2006/10/19 14:46:16 UTC
[jira] Created: (AMQ-995) An unhandled exception in the
TcpTransports' reader thread should close the connection (and inform the
app)
An unhandled exception in the TcpTransports' reader thread should close the connection (and inform the app)
-----------------------------------------------------------------------------------------------------------
Key: AMQ-995
URL: https://issues.apache.org/activemq/browse/AMQ-995
Project: ActiveMQ
Issue Type: Bug
Components: NMS (C# client)
Affects Versions: 4.0.2
Environment: Windows
Reporter: Rob Lugt
If the reader thread throws an exception (e.g. IOException) then the socket should be closed to prevent further messages being sent to the broker. If an exception is thrown during the marshalling of a message then there's no way for the stream to be set to the beginning of the next message, so all communication with the broker should cease at that point. Similarly, if the broker is killed, an IOException will probably be detected in the read thread first.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/activemq/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (AMQ-995) An unhandled exception in the
TcpTransports' reader thread should close the connection (and inform the
app)
Posted by "Rob Lugt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQ-995?page=all ]
Rob Lugt updated AMQ-995:
-------------------------
Attachment: AtomicBoolean.cs
Added Value property
> An unhandled exception in the TcpTransports' reader thread should close the connection (and inform the app)
> -----------------------------------------------------------------------------------------------------------
>
> Key: AMQ-995
> URL: https://issues.apache.org/activemq/browse/AMQ-995
> Project: ActiveMQ
> Issue Type: Bug
> Components: NMS (C# client)
> Affects Versions: 4.0.2
> Environment: Windows
> Reporter: Rob Lugt
> Assigned To: james strachan
> Attachments: amq995-patch.txt, AtomicBoolean.cs
>
>
> If the reader thread throws an exception (e.g. IOException) then the socket should be closed to prevent further messages being sent to the broker. If an exception is thrown during the marshalling of a message then there's no way for the stream to be set to the beginning of the next message, so all communication with the broker should cease at that point. Similarly, if the broker is killed, an IOException will probably be detected in the read thread first.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/activemq/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (AMQ-995) An unhandled exception in the
TcpTransports' reader thread should close the connection (and inform the
app)
Posted by "Rob Lugt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQ-995?page=all ]
Rob Lugt updated AMQ-995:
-------------------------
Attachment: amq995-patch.txt
> An unhandled exception in the TcpTransports' reader thread should close the connection (and inform the app)
> -----------------------------------------------------------------------------------------------------------
>
> Key: AMQ-995
> URL: https://issues.apache.org/activemq/browse/AMQ-995
> Project: ActiveMQ
> Issue Type: Bug
> Components: NMS (C# client)
> Affects Versions: 4.0.2
> Environment: Windows
> Reporter: Rob Lugt
> Assigned To: james strachan
> Attachments: amq995-patch.txt, AtomicBoolean.cs
>
>
> If the reader thread throws an exception (e.g. IOException) then the socket should be closed to prevent further messages being sent to the broker. If an exception is thrown during the marshalling of a message then there's no way for the stream to be set to the beginning of the next message, so all communication with the broker should cease at that point. Similarly, if the broker is killed, an IOException will probably be detected in the read thread first.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/activemq/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (AMQ-995) An unhandled exception in the
TcpTransports' reader thread should close the connection (and inform the
app)
Posted by "Rob Lugt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQ-995?page=all ]
Rob Lugt updated AMQ-995:
-------------------------
Attachment: (was: amq995-patch.txt)
> An unhandled exception in the TcpTransports' reader thread should close the connection (and inform the app)
> -----------------------------------------------------------------------------------------------------------
>
> Key: AMQ-995
> URL: https://issues.apache.org/activemq/browse/AMQ-995
> Project: ActiveMQ
> Issue Type: Bug
> Components: NMS (C# client)
> Affects Versions: 4.0.2
> Environment: Windows
> Reporter: Rob Lugt
> Assigned To: james strachan
> Attachments: AtomicBoolean.cs
>
>
> If the reader thread throws an exception (e.g. IOException) then the socket should be closed to prevent further messages being sent to the broker. If an exception is thrown during the marshalling of a message then there's no way for the stream to be set to the beginning of the next message, so all communication with the broker should cease at that point. Similarly, if the broker is killed, an IOException will probably be detected in the read thread first.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/activemq/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (AMQ-995) An unhandled exception in the
TcpTransports' reader thread should close the connection (and inform the
app)
Posted by "Rob Lugt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQ-995?page=all ]
Rob Lugt updated AMQ-995:
-------------------------
Attachment: amq995-patch.txt
Note: This patch requires revised version of AtomicBoolean (attached)
> An unhandled exception in the TcpTransports' reader thread should close the connection (and inform the app)
> -----------------------------------------------------------------------------------------------------------
>
> Key: AMQ-995
> URL: https://issues.apache.org/activemq/browse/AMQ-995
> Project: ActiveMQ
> Issue Type: Bug
> Components: NMS (C# client)
> Affects Versions: 4.0.2
> Environment: Windows
> Reporter: Rob Lugt
> Assigned To: james strachan
> Attachments: amq995-patch.txt
>
>
> If the reader thread throws an exception (e.g. IOException) then the socket should be closed to prevent further messages being sent to the broker. If an exception is thrown during the marshalling of a message then there's no way for the stream to be set to the beginning of the next message, so all communication with the broker should cease at that point. Similarly, if the broker is killed, an IOException will probably be detected in the read thread first.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/activemq/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (AMQ-995) An unhandled exception in the
TcpTransports' reader thread should close the connection (and inform the
app)
Posted by "Rob Lugt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQ-995?page=all ]
Rob Lugt updated AMQ-995:
-------------------------
Attachment: amq995-patch.txt
Attached patch does 3 things:
1) Adds explitic Close() method and allows Close/Dispose to be called multipel times
2) Differentiates between exceptions that occur during read/parse and those that occur in the message handler
3) Closes socket if IO exception occurs to prevent further use of the (now invalid) socket.
> An unhandled exception in the TcpTransports' reader thread should close the connection (and inform the app)
> -----------------------------------------------------------------------------------------------------------
>
> Key: AMQ-995
> URL: https://issues.apache.org/activemq/browse/AMQ-995
> Project: ActiveMQ
> Issue Type: Bug
> Components: NMS (C# client)
> Affects Versions: 4.0.2
> Environment: Windows
> Reporter: Rob Lugt
> Attachments: amq995-patch.txt
>
>
> If the reader thread throws an exception (e.g. IOException) then the socket should be closed to prevent further messages being sent to the broker. If an exception is thrown during the marshalling of a message then there's no way for the stream to be set to the beginning of the next message, so all communication with the broker should cease at that point. Similarly, if the broker is killed, an IOException will probably be detected in the read thread first.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/activemq/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (AMQ-995) An unhandled exception in the
TcpTransports' reader thread should close the connection (and inform the
app)
Posted by "Rob Lugt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQ-995?page=all ]
Rob Lugt reassigned AMQ-995:
----------------------------
Assignee: james strachan
Hi James. Please review and apply supplied patch.
> An unhandled exception in the TcpTransports' reader thread should close the connection (and inform the app)
> -----------------------------------------------------------------------------------------------------------
>
> Key: AMQ-995
> URL: https://issues.apache.org/activemq/browse/AMQ-995
> Project: ActiveMQ
> Issue Type: Bug
> Components: NMS (C# client)
> Affects Versions: 4.0.2
> Environment: Windows
> Reporter: Rob Lugt
> Assigned To: james strachan
> Attachments: amq995-patch.txt
>
>
> If the reader thread throws an exception (e.g. IOException) then the socket should be closed to prevent further messages being sent to the broker. If an exception is thrown during the marshalling of a message then there's no way for the stream to be set to the beginning of the next message, so all communication with the broker should cease at that point. Similarly, if the broker is killed, an IOException will probably be detected in the read thread first.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/activemq/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (AMQ-995) An unhandled exception in the
TcpTransports' reader thread should close the connection (and inform the
app)
Posted by "james strachan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQ-995?page=all ]
james strachan resolved AMQ-995.
--------------------------------
Fix Version/s: 4.1
Resolution: Fixed
Patch applied Rob - thanks again! :)
> An unhandled exception in the TcpTransports' reader thread should close the connection (and inform the app)
> -----------------------------------------------------------------------------------------------------------
>
> Key: AMQ-995
> URL: https://issues.apache.org/activemq/browse/AMQ-995
> Project: ActiveMQ
> Issue Type: Bug
> Components: NMS (C# client)
> Affects Versions: 4.0.2
> Environment: Windows
> Reporter: Rob Lugt
> Assigned To: james strachan
> Fix For: 4.1
>
> Attachments: amq995-patch.txt, AtomicBoolean.cs
>
>
> If the reader thread throws an exception (e.g. IOException) then the socket should be closed to prevent further messages being sent to the broker. If an exception is thrown during the marshalling of a message then there's no way for the stream to be set to the beginning of the next message, so all communication with the broker should cease at that point. Similarly, if the broker is killed, an IOException will probably be detected in the read thread first.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/activemq/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (AMQ-995) An unhandled exception in the
TcpTransports' reader thread should close the connection (and inform the
app)
Posted by "Rob Lugt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/AMQ-995?page=all ]
Rob Lugt updated AMQ-995:
-------------------------
Attachment: (was: amq995-patch.txt)
> An unhandled exception in the TcpTransports' reader thread should close the connection (and inform the app)
> -----------------------------------------------------------------------------------------------------------
>
> Key: AMQ-995
> URL: https://issues.apache.org/activemq/browse/AMQ-995
> Project: ActiveMQ
> Issue Type: Bug
> Components: NMS (C# client)
> Affects Versions: 4.0.2
> Environment: Windows
> Reporter: Rob Lugt
> Assigned To: james strachan
>
> If the reader thread throws an exception (e.g. IOException) then the socket should be closed to prevent further messages being sent to the broker. If an exception is thrown during the marshalling of a message then there's no way for the stream to be set to the beginning of the next message, so all communication with the broker should cease at that point. Similarly, if the broker is killed, an IOException will probably be detected in the read thread first.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/activemq/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira