[GitHub] [lucene] rmuir commented on pull request #819: fail clearly on too-new JDK

[GitBox <gi...@apache.org>]

rmuir commented on PR #819:
URL: https://github.com/apache/lucene/pull/819#issuecomment-1102995607

   > Yep. I wonder if we could do it in one script (the downloader?) to avoid running java so many times but overall I think it's better than before. :)
   
   I agree with this (as someone who disables the daemon and runs the commands every time). The only reason I specified it as a different command was due to the fact that if the downloader fails, the error is "trapped" and an additional version-related error (that you need at least java 11) is printed... IMO that's a bit confusing, but I get it.
   
   > 
   > This also reminds me that the various java versions (minimum required for Lucene, minimum required for gradle) are scattered around in oh-so-many places. I wonder how we could somehow centralize this information. I don't have any clean ideas though.
   
   Maybe it could be in a .properties file? Not gradle, not groovy, a real actual .properties file that we can read with java.io.Properties too?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org