You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by fh...@apache.org on 2020/06/23 18:12:13 UTC

[tomcat] branch 9.0.x updated: Make `ant -f mvn-pub.xml generic-install` work with the new ant tasks

This is an automated email from the ASF dual-hosted git repository.

fhanik pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/9.0.x by this push:
     new 919183b  Make `ant -f mvn-pub.xml generic-install` work with the new ant tasks
919183b is described below

commit 919183b438e1a2f0004082c69e34accc0c3e2f16
Author: Filip Hanik <fh...@pivotal.io>
AuthorDate: Tue Jun 23 11:11:24 2020 -0700

    Make `ant -f mvn-pub.xml generic-install` work with the new ant tasks
---
 res/maven/mvn-pub.xml | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/res/maven/mvn-pub.xml b/res/maven/mvn-pub.xml
index ea504a2..15e9380 100644
--- a/res/maven/mvn-pub.xml
+++ b/res/maven/mvn-pub.xml
@@ -50,8 +50,11 @@
       </filterset>
     </copy>
 
-    <resolver:install file="${file}">
+    <resolver:install>
+      <artifact file="${file}" />
       <pom file="${pom}.tmp"/>
+      <artifact file="${file}.asc" type="jar.asc" if:set="gpg.passphrase"/>
+      <artifact file="${pom}.asc" type="pom.asc" if:set="gpg.passphrase"/>
     </resolver:install>
 
     <delete file="${pom}.tmp"/>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


RE: [tomcat] branch 9.0.x updated: Make `ant -f mvn-pub.xml generic-install` work with the new ant tasks

Posted by Filip Hanik <fh...@vmware.com>.
Using outlook client, let's see if inline is working.

-----Original Message-----
From: Konstantin Kolinko <kn...@gmail.com> 
Sent: Tuesday, June 23, 2020 11:36 AM
To: Tomcat Developers List <de...@tomcat.apache.org>
Subject: Re: [tomcat] branch 9.0.x updated: Make `ant -f mvn-pub.xml generic-install` work with the new ant tasks

вт, 23 июн. 2020 г. в 21:12, <fh...@apache.org>:
>
> This is an automated email from the ASF dual-hosted git repository.
>
> fhanik pushed a commit to branch 9.0.x in repository 
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitb
> ox.apache.org%2Frepos%2Fasf%2Ftomcat.git&amp;data=02%7C01%7Cfhanik%40v
> mware.com%7Cac447e5f1a44447e2d9f08d817a441a0%7Cb39138ca3cee4b4aa4d6cd8
> 3d9dd62f0%7C0%7C0%7C637285341532942037&amp;sdata=QdBU7HneXndHvtLeai%2F
> brr1jHfcXAmmzcAcvbzej2Js%3D&amp;reserved=0
>
>
> The following commit(s) were added to refs/heads/9.0.x by this push:
>      new 919183b  Make `ant -f mvn-pub.xml generic-install` work with 
> the new ant tasks 919183b is described below
>
> commit 919183b438e1a2f0004082c69e34accc0c3e2f16
> Author: Filip Hanik <fh...@pivotal.io>
> AuthorDate: Tue Jun 23 11:11:24 2020 -0700
>
>     Make `ant -f mvn-pub.xml generic-install` work with the new ant 
> tasks

1) What is meant by "new tasks"?

Filip:
We switched the ant tasks for Maven 
https://github.com/apache/tomcat/commit/5db7d814d046e8aa39ea2252343fba386a497f2e#diff-8009cab2171819dc35701f82f3b196b6

I see that mvn.properties.default has
maven-resolver-ant-tasks.version=1.2.0

Does it need an update to 1.2.1 (the latest version at Maven Central, dated 2020-05-29)?
Or is it about some upcoming/snapshot version?

Filip:
I don't think so. The new task <resolver:install> doesn't have a file attribute.

2) This is 9.0.x. The master/10.0.x branch has not been updated yet.

Filip: Coming up

> ---
>  res/maven/mvn-pub.xml | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/res/maven/mvn-pub.xml b/res/maven/mvn-pub.xml index 
> ea504a2..15e9380 100644
> --- a/res/maven/mvn-pub.xml
> +++ b/res/maven/mvn-pub.xml
> @@ -50,8 +50,11 @@
>        </filterset>
>      </copy>
>
> -    <resolver:install file="${file}">
> +    <resolver:install>
> +      <artifact file="${file}" />
>        <pom file="${pom}.tmp"/>
> +      <artifact file="${file}.asc" type="jar.asc" if:set="gpg.passphrase"/>
> +      <artifact file="${pom}.asc" type="pom.asc" 
> + if:set="gpg.passphrase"/>
>      </resolver:install>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org


Re: [tomcat] branch 9.0.x updated: Make `ant -f mvn-pub.xml generic-install` work with the new ant tasks

Posted by Konstantin Kolinko <kn...@gmail.com>.
вт, 23 июн. 2020 г. в 21:12, <fh...@apache.org>:
>
> This is an automated email from the ASF dual-hosted git repository.
>
> fhanik pushed a commit to branch 9.0.x
> in repository https://gitbox.apache.org/repos/asf/tomcat.git
>
>
> The following commit(s) were added to refs/heads/9.0.x by this push:
>      new 919183b  Make `ant -f mvn-pub.xml generic-install` work with the new ant tasks
> 919183b is described below
>
> commit 919183b438e1a2f0004082c69e34accc0c3e2f16
> Author: Filip Hanik <fh...@pivotal.io>
> AuthorDate: Tue Jun 23 11:11:24 2020 -0700
>
>     Make `ant -f mvn-pub.xml generic-install` work with the new ant tasks

1) What is meant by "new tasks"?
I see that mvn.properties.default has
maven-resolver-ant-tasks.version=1.2.0

Does it need an update to 1.2.1 (the latest version at Maven Central,
dated 2020-05-29)?
Or is it about some upcoming/snapshot version?

2) This is 9.0.x. The master/10.0.x branch has not been updated yet.


> ---
>  res/maven/mvn-pub.xml | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/res/maven/mvn-pub.xml b/res/maven/mvn-pub.xml
> index ea504a2..15e9380 100644
> --- a/res/maven/mvn-pub.xml
> +++ b/res/maven/mvn-pub.xml
> @@ -50,8 +50,11 @@
>        </filterset>
>      </copy>
>
> -    <resolver:install file="${file}">
> +    <resolver:install>
> +      <artifact file="${file}" />
>        <pom file="${pom}.tmp"/>
> +      <artifact file="${file}.asc" type="jar.asc" if:set="gpg.passphrase"/>
> +      <artifact file="${pom}.asc" type="pom.asc" if:set="gpg.passphrase"/>
>      </resolver:install>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org