[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #3397: ARTEMIS-3050 Reduce PagedReferenceImpl memory footprint

[GitBox <gi...@apache.org>]

clebertsuconic commented on a change in pull request #3397:
URL: https://github.com/apache/activemq-artemis/pull/3397#discussion_r555475824



##########
File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/PagedReferenceImpl.java
##########
@@ -30,10 +30,9 @@
 import org.apache.activemq.artemis.core.server.ServerConsumer;
 import org.apache.activemq.artemis.core.server.impl.AckReason;
 import org.apache.activemq.artemis.core.transaction.Transaction;
-import org.apache.activemq.artemis.utils.collections.LinkedListImpl;
 import org.jboss.logging.Logger;
 
-public class PagedReferenceImpl extends LinkedListImpl.Node<PagedReferenceImpl> implements PagedReference, Runnable {

Review comment:
       This was an optimization you performed some time ago, to speed up things on the delivering... Queue.references...
   
   Are you sure about this change? Did you validate perf on it?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org