[GitHub] [nifi] mattyb149 commented on pull request #4268: MINIFI-488: Allow flow construction from YAML config

[GitBox <gi...@apache.org>]

mattyb149 commented on pull request #4268:
URL: https://github.com/apache/nifi/pull/4268#issuecomment-631697641


   Definitely pros and cons to both. If we incrementally bring over code from MiNiFi, we need to keep up to date with any commits that are happening in the MINIFI repo, plus there's the duplication as you mentioned. Working in a branch until MiNiFi is fully in NiFi means we have to keep up with commits in NiFi master on the branch, some of which may be fairly invasive.
   
   If I had to pick, I think the branch strategy is the better of the two, as the code can be brought over "all at once" so to speak, and we don't have to worry about refactoring code that we bring in piecemeal. The final PR will be a beast but as you said we'll have to pay the price someday, better to only pay it once.
   
   If you agree, I can close this PR and continuing working in my branch.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org