You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/04/20 01:42:31 UTC

[GitHub] [apisix-dashboard] Jaycean commented on a change in pull request #1779: feat: Improve debug view

Jaycean commented on a change in pull request #1779:
URL: https://github.com/apache/apisix-dashboard/pull/1779#discussion_r616284470



##########
File path: api/internal/handler/route_online_debug/route_online_debug.go
##########
@@ -134,7 +136,20 @@ func (h *HTTPProtocolSupport) RequestForwarding(c droplet.Context) (interface{},
 
 	defer resp.Body.Close()
 
-	_body, err := ioutil.ReadAll(resp.Body)
+	// handle gzip content encoding
+	var reader io.ReadCloser
+	switch resp.Header.Get("Content-Encoding") {
+	case "gzip":

Review comment:
       Also need E2E test case.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org