Re: [PR] SOLR-17533: Rearrange and cleanup solr.cmd [solr]

["malliaridis (via GitHub)" <gi...@apache.org>]

malliaridis commented on code in PR #2822:
URL: https://github.com/apache/solr/pull/2822#discussion_r1835368230


##########
solr/bin/solr.cmd:
##########
@@ -383,18 +355,19 @@ goto done
 @echo.
 goto done
 
-
-REM Really basic command-line arg parsing
+REM Parse arguments for special commands (start, stop, restart)

Review Comment:
   This part is skipped in case of the auth command. The auth command has its own parsing plus the java class parsing. If I am not mistaken, this was the same behavior before and if I am not mistaken `bin/solr` does the same. Correct me if I am wrong though.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org