[GitHub] [arrow] alamb commented on a change in pull request #7959: ARROW-9654: [Rust][DataFusion] Add `EXPLAIN ` statement

[GitBox <gi...@apache.org>]

alamb commented on a change in pull request #7959:
URL: https://github.com/apache/arrow/pull/7959#discussion_r470165435



##########
File path: rust/datafusion/src/logicalplan.rs
##########
@@ -784,6 +784,18 @@ pub enum LogicalPlan {
         /// Whether the CSV file contains a header
         has_header: bool,
     },
+    /// Produces a relation with string representations of
+    /// various parts of the plan
+    Explain {

Review comment:
       In a subsequent PR, I would like to suggest we consider making this `Explain(ExplainNode)` or something, and having a separate `struct ExplainNode` with these fields. There is a bunch of boiler plate code for matching and reconstructing `LogicalPlanner` nodes that I think would be less awkward (and require fewer changes to add / modify fields)  if they were collected into a struct




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org