You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "lostluck (via GitHub)" <gi...@apache.org> on 2023/02/15 20:59:28 UTC
[GitHub] [beam] lostluck opened a new pull request, #25497: [#24789][prism] internal/jobservices metrics + tests
lostluck opened a new pull request, #25497:
URL: https://github.com/apache/beam/pull/25497
Adds metrics store handling and initial unit tests.
For Prism's initial implementation.
See https://github.com/apache/beam/issues/24789.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] jrmccluskey commented on a diff in pull request #25497: [#24789][prism] internal/jobservices metrics + tests
Posted by "jrmccluskey (via GitHub)" <gi...@apache.org>.
jrmccluskey commented on code in PR #25497:
URL: https://github.com/apache/beam/pull/25497#discussion_r1107763877
##########
sdks/go/pkg/beam/runners/prism/internal/jobservices/metrics.go:
##########
@@ -0,0 +1,497 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package jobservices
+
+import (
+ "bytes"
+ "fmt"
+ "hash/maphash"
+ "math"
+ "sort"
+ "sync"
+
+ "github.com/apache/beam/sdks/v2/go/pkg/beam/core/graph/coder"
+ "github.com/apache/beam/sdks/v2/go/pkg/beam/core/metrics"
+ fnpb "github.com/apache/beam/sdks/v2/go/pkg/beam/model/fnexecution_v1"
+ pipepb "github.com/apache/beam/sdks/v2/go/pkg/beam/model/pipeline_v1"
+ "golang.org/x/exp/constraints"
+ "golang.org/x/exp/slog"
+ "google.golang.org/protobuf/proto"
+ "google.golang.org/protobuf/reflect/protoreflect"
+)
+
+type labelsToKeyFunc func(string, map[string]string) metricKey
+
+type urnOps struct {
+ // keyFn produces the key for this metric from the labels.
+ // based on the required label set for the metric from it's spec.
+ keyFn labelsToKeyFunc
+ // newAccum produces an accumulator assuming we don't have an accumulator for it already.
+ // based on the type urn of the metric from it's spec.
+ newAccum accumFactory
+}
+
+var (
+ mUrn2Ops = map[string]urnOps{}
+)
+
+func init() {
+ mUrn2Spec := map[string]*pipepb.MonitoringInfoSpec{}
+ specs := (pipepb.MonitoringInfoSpecs_Enum)(0).Descriptor().Values()
+ for i := 0; i < specs.Len(); i++ {
+ enum := specs.ByNumber(protoreflect.EnumNumber(i))
+ spec := proto.GetExtension(enum.Options(), pipepb.E_MonitoringInfoSpec).(*pipepb.MonitoringInfoSpec)
+ mUrn2Spec[spec.GetUrn()] = spec
+ }
+ mUrn2Ops = buildUrnToOpsMap(mUrn2Spec)
+}
+
+// Should probably just construct a slice or map to get the urns out
+// since we'll ultimately be using them alot.
Review Comment:
```suggestion
// since we'll ultimately be using them a lot.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #25497: [#24789][prism] internal/jobservices metrics + tests
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #25497:
URL: https://github.com/apache/beam/pull/25497#issuecomment-1433603700
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] jrmccluskey commented on pull request #25497: [#24789][prism] internal/jobservices metrics + tests
Posted by "jrmccluskey (via GitHub)" <gi...@apache.org>.
jrmccluskey commented on PR #25497:
URL: https://github.com/apache/beam/pull/25497#issuecomment-1433527569
There's also a fix for the pull_licenses step in flight at #25515
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck merged pull request #25497: [#24789][prism] internal/jobservices metrics + tests
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck merged PR #25497:
URL: https://github.com/apache/beam/pull/25497
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #25497: [#24789][prism] internal/jobservices metrics + tests
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #25497:
URL: https://github.com/apache/beam/pull/25497#issuecomment-1432041848
Run GoPortable PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #25497: [#24789][prism] internal/jobservices metrics + tests
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #25497:
URL: https://github.com/apache/beam/pull/25497#issuecomment-1432042397
R: @jrmccluskey
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org