You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Pradeep Agrawal <pr...@gmail.com> on 2020/06/10 10:05:34 UTC
Review Request 72580: RANGER-2852: Add .gitattributes file to prevent
CRLF and LF mismatches for source and text files
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72580/
-----------------------------------------------------------
Review request for ranger, Ankita Sinha, Don Bosco Durai, bhavik patel, Colm O hEigeartaigh, Gautam Borad, Jayendra Parab, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Nikhil P, Nitin Galave, pengjianhua, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, Velmurugan Periasamy, Qiang Zhang, and Zsombor Gegesy.
Bugs: RANGER-2852
https://issues.apache.org/jira/browse/RANGER-2852
Repository: ranger
Description
-------
**Problem Statement:** When existing java file have ^M character then patch does not get apply.
Source code in Ranger repo has several files that have CRLF endings.
With more development happening on windows there is a higher chance of more CRLF files getting into the source code.
**Proposed Solution:**
Inspired from HADOOP-8911 and HADOOP-8912
I would like to avoid that by creating .gitattributes file which prevents sources from having CRLF entries in text files.
I am adding a couple of links here to give more primer on what exactly is the issue and how we can try to fix it.
http://git-scm.com/docs/gitattributes#_checking_out_and_checking_in
http://stackoverflow.com/questions/170961/whats-the-best-crlf-handling-strategy-with-git
Diffs
-----
.gitattributes PRE-CREATION
Diff: https://reviews.apache.org/r/72580/diff/1/
Testing
-------
Build successful with this patch.
Thanks,
Pradeep Agrawal