You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/19 13:57:34 UTC

[GitHub] [spark] Yikun opened a new pull request, #37583: [SPARK-38961][PS] Raise ImportError if pandas version mismatch when creating PS document "Supported APIs"

Yikun opened a new pull request, #37583:
URL: https://github.com/apache/spark/pull/37583

   ### What changes were proposed in this pull request?
   Raise ImportError when creating PS document "Supported APIs" but pandas version mismatch
   
   ### Why are the changes needed?
   The pyspark.pandas documentation "Supported APIs" will be auto-generated. ([SPARK-38961](https://issues.apache.org/jira/browse/SPARK-38961)). At this point, we need to verify the version of pandas.
   
   Related: https://github.com/apache/spark/pull/36509#discussion_r871062738
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   
   ### How was this patch tested?
   CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon closed pull request #37583: [SPARK-39170][PS] Raise ImportError if pandas version mismatch when creating PS document "Supported APIs"

Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #37583: [SPARK-39170][PS] Raise ImportError if pandas version mismatch when creating PS document "Supported APIs"
URL: https://github.com/apache/spark/pull/37583


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #37583: [SPARK-39170][PS] Raise ImportError if pandas version mismatch when creating PS document "Supported APIs"

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #37583:
URL: https://github.com/apache/spark/pull/37583#issuecomment-1221190871

   Merged to master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] Yikun commented on pull request #37583: [SPARK-38961][PS] Raise ImportError if pandas version mismatch when creating PS document "Supported APIs"

Posted by GitBox <gi...@apache.org>.
Yikun commented on PR #37583:
URL: https://github.com/apache/spark/pull/37583#issuecomment-1220720125

   I remember what we need is pandas strong matching otherwise raise the import error, right?
   
   Mind to take a look? @beobest2 @HyukjinKwon 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] beobest2 commented on pull request #37583: [SPARK-39170][PS] Raise ImportError if pandas version mismatch when creating PS document "Supported APIs"

Posted by GitBox <gi...@apache.org>.
beobest2 commented on PR #37583:
URL: https://github.com/apache/spark/pull/37583#issuecomment-1221076128

   LGTM!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org