[jira] Commented: (HADOOP-7117) Move secondary namenode checkpoint configs from core-default.xml to hdfs-default.xml

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-7117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13007712#comment-13007712 ] 

Hadoop QA commented on HADOOP-7117:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12469585/HADOOP-7117.r1.diff
  against trunk revision 1081598.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/310//testReport/
Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/310//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://hudson.apache.org/hudson/job/PreCommit-HADOOP-Build/310//console

This message is automatically generated.

> Move secondary namenode checkpoint configs from core-default.xml to hdfs-default.xml
> ------------------------------------------------------------------------------------
>
>                 Key: HADOOP-7117
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7117
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: conf
>            Reporter: Patrick Angeles
>            Assignee: Harsh J Chouraria
>             Fix For: 0.23.0
>
>         Attachments: HADOOP-7117.r1.diff
>
>
> The following configs are in core-default.xml, but are really read by the Secondary Namenode. These should be moved to hdfs-default.xml for consistency.
> <property>
> <name>fs.checkpoint.dir</name>
> <value>${hadoop.tmp.dir}/dfs/namesecondary</value>
> <description>Determines where on the local filesystem the DFS secondary
> name node should store the temporary images to merge.
> If this is a comma-delimited list of directories then the image is
> replicated in all of the directories for redundancy.
> </description>
> </property>
> <property>
> <name>fs.checkpoint.edits.dir</name>
> <value>${fs.checkpoint.dir}</value>
> <description>Determines where on the local filesystem the DFS secondary
> name node should store the temporary edits to merge.
> If this is a comma-delimited list of directoires then teh edits is
> replicated in all of the directoires for redundancy.
> Default value is same as fs.checkpoint.dir
> </description>
> </property>
> <property>
> <name>fs.checkpoint.period</name>
> <value>3600</value>
> <description>The number of seconds between two periodic checkpoints.
> </description>
> </property>
> <property>
> <name>fs.checkpoint.size</name>
> <value>67108864</value>
> <description>The size of the current edit log (in bytes) that triggers
> a periodic checkpoint even if the fs.checkpoint.period hasn't expired.
> </description>
> </property>

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira