You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Nixon Rodrigues <ni...@freestoneinfotech.com> on 2016/06/10 13:10:12 UTC
Review Request 48550: ATLAS-869 - Make LDAP/AD properties to be
configurable.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48550/
-----------------------------------------------------------
Review request for atlas, Gautam Borad, Madhan Neethiraj, Mehul Parikh, Shwetha GS, Suma Shivaprasad, and Hemanth Yamijala.
Bugs: ATLAS-869
https://issues.apache.org/jira/browse/ATLAS-869
Repository: atlas
Description
-------
Currently the LDAP/AD configartion properties are in atlas-admin-site.xml, which is bundled with webapp.
End user should be able to configure it, it has been moved to atlas-application.properties now.
Diffs
-----
distro/src/conf/atlas-application.properties bdd02d6
webapp/src/main/java/org/apache/atlas/web/security/AtlasADAuthenticationProvider.java 34063b0
webapp/src/main/java/org/apache/atlas/web/security/AtlasLdapAuthenticationProvider.java 6037858
webapp/src/main/resources/atlas-admin-site.xml c4b4be7
webapp/src/main/webapp/WEB-INF/applicationContext.xml 004c3a8
Diff: https://reviews.apache.org/r/48550/diff/
Testing
-------
Tested login via FILE/LDAP/AD authentication methods.
Thanks,
Nixon Rodrigues
Re: Review Request 48550: ATLAS-869 - Make LDAP/AD properties to be
configurable.
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48550/#review137235
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On June 10, 2016, 1:10 p.m., Nixon Rodrigues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48550/
> -----------------------------------------------------------
>
> (Updated June 10, 2016, 1:10 p.m.)
>
>
> Review request for atlas, Gautam Borad, Madhan Neethiraj, Mehul Parikh, Shwetha GS, Suma Shivaprasad, and Hemanth Yamijala.
>
>
> Bugs: ATLAS-869
> https://issues.apache.org/jira/browse/ATLAS-869
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Currently the LDAP/AD configartion properties are in atlas-admin-site.xml, which is bundled with webapp.
> End user should be able to configure it, it has been moved to atlas-application.properties now.
>
>
> Diffs
> -----
>
> distro/src/conf/atlas-application.properties bdd02d6
> webapp/src/main/java/org/apache/atlas/web/security/AtlasADAuthenticationProvider.java 34063b0
> webapp/src/main/java/org/apache/atlas/web/security/AtlasLdapAuthenticationProvider.java 6037858
> webapp/src/main/resources/atlas-admin-site.xml c4b4be7
> webapp/src/main/webapp/WEB-INF/applicationContext.xml 004c3a8
>
> Diff: https://reviews.apache.org/r/48550/diff/
>
>
> Testing
> -------
>
> Tested login via FILE/LDAP/AD authentication methods.
>
>
> Thanks,
>
> Nixon Rodrigues
>
>
Re: Review Request 48550: ATLAS-869 - Make LDAP/AD properties to be
configurable.
Posted by Hemanth Yamijala <yh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48550/#review137294
-----------------------------------------------------------
Ship it!
Ship It!
- Hemanth Yamijala
On June 13, 2016, 12:36 p.m., Nixon Rodrigues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48550/
> -----------------------------------------------------------
>
> (Updated June 13, 2016, 12:36 p.m.)
>
>
> Review request for atlas, Gautam Borad, Madhan Neethiraj, Mehul Parikh, Shwetha GS, Suma Shivaprasad, and Hemanth Yamijala.
>
>
> Bugs: ATLAS-869
> https://issues.apache.org/jira/browse/ATLAS-869
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Currently the LDAP/AD configartion properties are in atlas-admin-site.xml, which is bundled with webapp.
> End user should be able to configure it, it has been moved to atlas-application.properties now.
>
>
> Diffs
> -----
>
> distro/src/conf/atlas-application.properties 2b90086
> webapp/src/main/java/org/apache/atlas/web/security/AtlasADAuthenticationProvider.java 34063b0
> webapp/src/main/java/org/apache/atlas/web/security/AtlasLdapAuthenticationProvider.java 6037858
> webapp/src/main/resources/atlas-admin-site.xml c4b4be7
> webapp/src/main/webapp/WEB-INF/applicationContext.xml 004c3a8
>
> Diff: https://reviews.apache.org/r/48550/diff/
>
>
> Testing
> -------
>
> Tested login via FILE/LDAP/AD authentication methods.
>
>
> Thanks,
>
> Nixon Rodrigues
>
>
Re: Review Request 48550: ATLAS-869 - Make LDAP/AD properties to be
configurable.
Posted by Nixon Rodrigues <ni...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48550/
-----------------------------------------------------------
(Updated June 13, 2016, 12:36 p.m.)
Review request for atlas, Gautam Borad, Madhan Neethiraj, Mehul Parikh, Shwetha GS, Suma Shivaprasad, and Hemanth Yamijala.
Changes
-------
Changes includes setting example values to LDAP/AD properties
Bugs: ATLAS-869
https://issues.apache.org/jira/browse/ATLAS-869
Repository: atlas
Description
-------
Currently the LDAP/AD configartion properties are in atlas-admin-site.xml, which is bundled with webapp.
End user should be able to configure it, it has been moved to atlas-application.properties now.
Diffs (updated)
-----
distro/src/conf/atlas-application.properties 2b90086
webapp/src/main/java/org/apache/atlas/web/security/AtlasADAuthenticationProvider.java 34063b0
webapp/src/main/java/org/apache/atlas/web/security/AtlasLdapAuthenticationProvider.java 6037858
webapp/src/main/resources/atlas-admin-site.xml c4b4be7
webapp/src/main/webapp/WEB-INF/applicationContext.xml 004c3a8
Diff: https://reviews.apache.org/r/48550/diff/
Testing
-------
Tested login via FILE/LDAP/AD authentication methods.
Thanks,
Nixon Rodrigues
Re: Review Request 48550: ATLAS-869 - Make LDAP/AD properties to be
configurable.
Posted by Nixon Rodrigues <ni...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48550/
-----------------------------------------------------------
(Updated June 13, 2016, 11:03 a.m.)
Review request for atlas, Gautam Borad, Madhan Neethiraj, Mehul Parikh, Shwetha GS, Suma Shivaprasad, and Hemanth Yamijala.
Changes
-------
Changes include removal of LDAP/AD properties.
Bugs: ATLAS-869
https://issues.apache.org/jira/browse/ATLAS-869
Repository: atlas
Description
-------
Currently the LDAP/AD configartion properties are in atlas-admin-site.xml, which is bundled with webapp.
End user should be able to configure it, it has been moved to atlas-application.properties now.
Diffs (updated)
-----
distro/src/conf/atlas-application.properties 2b90086
webapp/src/main/java/org/apache/atlas/web/security/AtlasADAuthenticationProvider.java 34063b0
webapp/src/main/java/org/apache/atlas/web/security/AtlasLdapAuthenticationProvider.java 6037858
webapp/src/main/resources/atlas-admin-site.xml c4b4be7
webapp/src/main/webapp/WEB-INF/applicationContext.xml 004c3a8
Diff: https://reviews.apache.org/r/48550/diff/
Testing
-------
Tested login via FILE/LDAP/AD authentication methods.
Thanks,
Nixon Rodrigues
Re: Review Request 48550: ATLAS-869 - Make LDAP/AD properties to be
configurable.
Posted by Hemanth Yamijala <yh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48550/#review137241
-----------------------------------------------------------
distro/src/conf/atlas-application.properties (line 98)
<https://reviews.apache.org/r/48550/#comment202402>
I don't think we should hardcode these. Can you please remove?
- Hemanth Yamijala
On June 10, 2016, 1:10 p.m., Nixon Rodrigues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48550/
> -----------------------------------------------------------
>
> (Updated June 10, 2016, 1:10 p.m.)
>
>
> Review request for atlas, Gautam Borad, Madhan Neethiraj, Mehul Parikh, Shwetha GS, Suma Shivaprasad, and Hemanth Yamijala.
>
>
> Bugs: ATLAS-869
> https://issues.apache.org/jira/browse/ATLAS-869
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Currently the LDAP/AD configartion properties are in atlas-admin-site.xml, which is bundled with webapp.
> End user should be able to configure it, it has been moved to atlas-application.properties now.
>
>
> Diffs
> -----
>
> distro/src/conf/atlas-application.properties bdd02d6
> webapp/src/main/java/org/apache/atlas/web/security/AtlasADAuthenticationProvider.java 34063b0
> webapp/src/main/java/org/apache/atlas/web/security/AtlasLdapAuthenticationProvider.java 6037858
> webapp/src/main/resources/atlas-admin-site.xml c4b4be7
> webapp/src/main/webapp/WEB-INF/applicationContext.xml 004c3a8
>
> Diff: https://reviews.apache.org/r/48550/diff/
>
>
> Testing
> -------
>
> Tested login via FILE/LDAP/AD authentication methods.
>
>
> Thanks,
>
> Nixon Rodrigues
>
>