You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by se...@apache.org on 2015/08/13 23:54:23 UTC

svn commit: r1695785 - /commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Utility.java

Author: sebb
Date: Thu Aug 13 21:54:22 2015
New Revision: 1695785

URL: http://svn.apache.org/r1695785
Log:
BCEL-197 Fix typo

Modified:
    commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Utility.java

Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Utility.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Utility.java?rev=1695785&r1=1695784&r2=1695785&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Utility.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Utility.java Thu Aug 13 21:54:22 2015
@@ -861,10 +861,10 @@ public abstract class Utility {
                     // check for wildcards
                     if (signature.charAt(consumed_chars) == '+') {
                         type = type + "? extends ";
-                        consumed_chars = ++consumed_chars;
+                        consumed_chars++;
                     } else if (signature.charAt(consumed_chars) == '-') {
                         type = type + "? super ";
-                        consumed_chars = ++consumed_chars;
+                        consumed_chars++;
                     } else if (signature.charAt(consumed_chars) == '*') {
                         // must be at end of signature
                         if (signature.charAt(consumed_chars + 1) != '>') {



Re: svn commit: r1695785 - /commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Utility.java

Posted by Gary Gregory <ga...@gmail.com>.
That was some wacky code you just fixed up!

Gary

On Thu, Aug 13, 2015 at 2:54 PM, <se...@apache.org> wrote:

> Author: sebb
> Date: Thu Aug 13 21:54:22 2015
> New Revision: 1695785
>
> URL: http://svn.apache.org/r1695785
> Log:
> BCEL-197 Fix typo
>
> Modified:
>
> commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Utility.java
>
> Modified:
> commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Utility.java
> URL:
> http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Utility.java?rev=1695785&r1=1695784&r2=1695785&view=diff
>
> ==============================================================================
> ---
> commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Utility.java
> (original)
> +++
> commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/Utility.java
> Thu Aug 13 21:54:22 2015
> @@ -861,10 +861,10 @@ public abstract class Utility {
>                      // check for wildcards
>                      if (signature.charAt(consumed_chars) == '+') {
>                          type = type + "? extends ";
> -                        consumed_chars = ++consumed_chars;
> +                        consumed_chars++;
>                      } else if (signature.charAt(consumed_chars) == '-') {
>                          type = type + "? super ";
> -                        consumed_chars = ++consumed_chars;
> +                        consumed_chars++;
>                      } else if (signature.charAt(consumed_chars) == '*') {
>                          // must be at end of signature
>                          if (signature.charAt(consumed_chars + 1) != '>') {
>
>
>


-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory