You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/10/07 08:32:53 UTC

[GitHub] [iotdb] qiaojialin commented on a change in pull request #1791: [IOTDB-912] Implement wasNull method in AbstractIoTDBJDBCResultSet

qiaojialin commented on a change in pull request #1791:
URL: https://github.com/apache/iotdb/pull/1791#discussion_r500833080



##########
File path: service-rpc/src/main/java/org/apache/iotdb/rpc/IoTDBRpcDataSet.java
##########
@@ -343,9 +352,11 @@ public long getLong(String columnName) throws StatementExecutionException {
     }
     int index = columnOrdinalMap.get(columnName) - START_INDEX;
     if (!isNull(index, rowsIndex - 1)) {
+      lastReadWasNull = false;
       return BytesUtils.bytesToLong(values[index]);
     } else {
-      throw new StatementExecutionException(String.format(VALUE_IS_NULL, columnName));

Review comment:
       Maybe throw an exception is better? which can help users find bugs in client




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org