You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Mikhail Bautin (Created) (JIRA)" <ji...@apache.org> on 2011/12/07 20:22:40 UTC
[jira] [Created] (HBASE-4976) Add compaction/flush queue size
metrics mistakenly removed by HFile v2
Add compaction/flush queue size metrics mistakenly removed by HFile v2
----------------------------------------------------------------------
Key: HBASE-4976
URL: https://issues.apache.org/jira/browse/HBASE-4976
Project: HBase
Issue Type: Bug
Reporter: Mikhail Bautin
Assignee: Mikhail Bautin
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4976) Add compaction/flush queue size
metrics mistakenly removed by HFile v2
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13164866#comment-13164866 ]
Phabricator commented on HBASE-4976:
------------------------------------
stack has commented on the revision "[jira] [HBASE-4976] Add compaction/flush queue size metrics mistakenly removed by HFile v2".
+1
REVISION DETAIL
https://reviews.facebook.net/D645
> Add compaction/flush queue size metrics mistakenly removed by HFile v2
> ----------------------------------------------------------------------
>
> Key: HBASE-4976
> URL: https://issues.apache.org/jira/browse/HBASE-4976
> Project: HBase
> Issue Type: Bug
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Priority: Blocker
> Fix For: 0.92.0
>
> Attachments: D645.1.patch
>
>
> Upping priority, and putting it against 0.92 since J-D fingered it as blocker. Which metrics in particular are missing? Hard to patch?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4976) Add compaction/flush queue size
metrics mistakenly removed by HFile v2
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165010#comment-13165010 ]
Hudson commented on HBASE-4976:
-------------------------------
Integrated in HBase-0.92-security #33 (See [https://builds.apache.org/job/HBase-0.92-security/33/])
HBASE-4976 Add compaction/flush queue size metrics mistakenly removed by HFile v2
stack :
Files :
* /hbase/branches/0.92/CHANGES.txt
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
> Add compaction/flush queue size metrics mistakenly removed by HFile v2
> ----------------------------------------------------------------------
>
> Key: HBASE-4976
> URL: https://issues.apache.org/jira/browse/HBASE-4976
> Project: HBase
> Issue Type: Bug
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Priority: Blocker
> Fix For: 0.92.0
>
> Attachments: D645.1.patch
>
>
> Upping priority, and putting it against 0.92 since J-D fingered it as blocker. Which metrics in particular are missing? Hard to patch?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4976) Add compaction/flush queue size
metrics mistakenly removed by HFile v2
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13164880#comment-13164880 ]
Phabricator commented on HBASE-4976:
------------------------------------
stack has commented on the revision "[jira] [HBASE-4976] Add compaction/flush queue size metrics mistakenly removed by HFile v2".
Will do in fugure M (Nicolas asked me do this in past too -- I'll get it eventually)
REVISION DETAIL
https://reviews.facebook.net/D645
> Add compaction/flush queue size metrics mistakenly removed by HFile v2
> ----------------------------------------------------------------------
>
> Key: HBASE-4976
> URL: https://issues.apache.org/jira/browse/HBASE-4976
> Project: HBase
> Issue Type: Bug
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Priority: Blocker
> Fix For: 0.92.0
>
> Attachments: D645.1.patch
>
>
> Upping priority, and putting it against 0.92 since J-D fingered it as blocker. Which metrics in particular are missing? Hard to patch?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4976) Add compaction/flush queue size
metrics mistakenly removed by HFile v2
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13164878#comment-13164878 ]
Phabricator commented on HBASE-4976:
------------------------------------
mbautin has abandoned the revision "[jira] [HBASE-4976] Add compaction/flush queue size metrics mistakenly removed by HFile v2".
Abandoning this revision -- this has been committed.
@stack / @jdcryans: could you please do "arc amend --revision <rev_number>" before committing patches posted as Phabricator diffs in the future? They will be marked as committed automatically in that case. E.g. for this diff the commit message generated by "arc amend" would be the following (out of all these lines, the "Differential Revision" line is the most important.)
[jira] [HBASE-4976] Add compaction/flush queue size metrics mistakenly removed
by HFile v2
Summary: Adding back compaction/flush queue size metrics mistakenly removed in
the patch
https://issues.apache.org/jira/secure/attachment/12489236/0001-review_hfile-v2-r1153300-git-1152532-2011_08_03_12_4.patch
Test Plan: Deploy HBase trunk to a dev cluster and observe metrics through JMX
Reviewers: stack, JIRA, jdcryans
Reviewed By: jdcryans
CC: jdcryans, stack
Differential Revision: 645
REVISION DETAIL
https://reviews.facebook.net/D645
> Add compaction/flush queue size metrics mistakenly removed by HFile v2
> ----------------------------------------------------------------------
>
> Key: HBASE-4976
> URL: https://issues.apache.org/jira/browse/HBASE-4976
> Project: HBase
> Issue Type: Bug
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Priority: Blocker
> Fix For: 0.92.0
>
> Attachments: D645.1.patch
>
>
> Upping priority, and putting it against 0.92 since J-D fingered it as blocker. Which metrics in particular are missing? Hard to patch?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HBASE-4976) Add compaction/flush queue size
metrics mistakenly removed by HFile v2
Posted by "stack (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack resolved HBASE-4976.
--------------------------
Resolution: Fixed
Hadoop Flags: Reviewed
Committed branch and trunk. Thanks for the patch Mikhail.
> Add compaction/flush queue size metrics mistakenly removed by HFile v2
> ----------------------------------------------------------------------
>
> Key: HBASE-4976
> URL: https://issues.apache.org/jira/browse/HBASE-4976
> Project: HBase
> Issue Type: Bug
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Priority: Blocker
> Fix For: 0.92.0
>
> Attachments: D645.1.patch
>
>
> Upping priority, and putting it against 0.92 since J-D fingered it as blocker. Which metrics in particular are missing? Hard to patch?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4976) Add compaction/flush queue size
metrics mistakenly removed by HFile v2
Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-4976:
-------------------------
Description: Upping priority, and putting it against 0.92 since J-D fingered it as blocker. Which metrics in particular are missing? Hard to patch?
Priority: Blocker (was: Major)
Fix Version/s: 0.92.0
> Add compaction/flush queue size metrics mistakenly removed by HFile v2
> ----------------------------------------------------------------------
>
> Key: HBASE-4976
> URL: https://issues.apache.org/jira/browse/HBASE-4976
> Project: HBase
> Issue Type: Bug
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Priority: Blocker
> Fix For: 0.92.0
>
>
> Upping priority, and putting it against 0.92 since J-D fingered it as blocker. Which metrics in particular are missing? Hard to patch?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4976) Add compaction/flush queue size
metrics mistakenly removed by HFile v2
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165090#comment-13165090 ]
Hudson commented on HBASE-4976:
-------------------------------
Integrated in HBase-TRUNK #2526 (See [https://builds.apache.org/job/HBase-TRUNK/2526/])
HBASE-4976 Add compaction/flush queue size metrics mistakenly removed by HFile v2
stack :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
> Add compaction/flush queue size metrics mistakenly removed by HFile v2
> ----------------------------------------------------------------------
>
> Key: HBASE-4976
> URL: https://issues.apache.org/jira/browse/HBASE-4976
> Project: HBase
> Issue Type: Bug
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Priority: Blocker
> Fix For: 0.92.0
>
> Attachments: D645.1.patch
>
>
> Upping priority, and putting it against 0.92 since J-D fingered it as blocker. Which metrics in particular are missing? Hard to patch?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4976) Add compaction/flush queue size
metrics mistakenly removed by HFile v2
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HBASE-4976:
-------------------------------
Attachment: D645.1.patch
mbautin requested code review of "[jira] [HBASE-4976] Add compaction/flush queue size metrics mistakenly removed by HFile v2".
Reviewers: stack, JIRA
Adding back compaction/flush queue size metrics mistakenly removed in the patch https://issues.apache.org/jira/secure/attachment/12489236/0001-review_hfile-v2-r1153300-git-1152532-2011_08_03_12_4.patch
TEST PLAN
Deploy HBase trunk to a dev cluster and observe metrics through JMX
REVISION DETAIL
https://reviews.facebook.net/D645
AFFECTED FILES
src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/1437/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> Add compaction/flush queue size metrics mistakenly removed by HFile v2
> ----------------------------------------------------------------------
>
> Key: HBASE-4976
> URL: https://issues.apache.org/jira/browse/HBASE-4976
> Project: HBase
> Issue Type: Bug
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Priority: Blocker
> Fix For: 0.92.0
>
> Attachments: D645.1.patch
>
>
> Upping priority, and putting it against 0.92 since J-D fingered it as blocker. Which metrics in particular are missing? Hard to patch?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4976) Add compaction/flush queue size
metrics mistakenly removed by HFile v2
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13164968#comment-13164968 ]
Hudson commented on HBASE-4976:
-------------------------------
Integrated in HBase-0.92 #176 (See [https://builds.apache.org/job/HBase-0.92/176/])
HBASE-4976 Add compaction/flush queue size metrics mistakenly removed by HFile v2
stack :
Files :
* /hbase/branches/0.92/CHANGES.txt
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
> Add compaction/flush queue size metrics mistakenly removed by HFile v2
> ----------------------------------------------------------------------
>
> Key: HBASE-4976
> URL: https://issues.apache.org/jira/browse/HBASE-4976
> Project: HBase
> Issue Type: Bug
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Priority: Blocker
> Fix For: 0.92.0
>
> Attachments: D645.1.patch
>
>
> Upping priority, and putting it against 0.92 since J-D fingered it as blocker. Which metrics in particular are missing? Hard to patch?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4976) Add compaction/flush queue size
metrics mistakenly removed by HFile v2
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13164862#comment-13164862 ]
Phabricator commented on HBASE-4976:
------------------------------------
jdcryans has accepted the revision "[jira] [HBASE-4976] Add compaction/flush queue size metrics mistakenly removed by HFile v2".
lgtm
REVISION DETAIL
https://reviews.facebook.net/D645
> Add compaction/flush queue size metrics mistakenly removed by HFile v2
> ----------------------------------------------------------------------
>
> Key: HBASE-4976
> URL: https://issues.apache.org/jira/browse/HBASE-4976
> Project: HBase
> Issue Type: Bug
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Priority: Blocker
> Fix For: 0.92.0
>
> Attachments: D645.1.patch
>
>
> Upping priority, and putting it against 0.92 since J-D fingered it as blocker. Which metrics in particular are missing? Hard to patch?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4976) Add compaction/flush queue size
metrics mistakenly removed by HFile v2
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165040#comment-13165040 ]
Hudson commented on HBASE-4976:
-------------------------------
Integrated in HBase-TRUNK-security #25 (See [https://builds.apache.org/job/HBase-TRUNK-security/25/])
HBASE-4976 Add compaction/flush queue size metrics mistakenly removed by HFile v2
stack :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
> Add compaction/flush queue size metrics mistakenly removed by HFile v2
> ----------------------------------------------------------------------
>
> Key: HBASE-4976
> URL: https://issues.apache.org/jira/browse/HBASE-4976
> Project: HBase
> Issue Type: Bug
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Priority: Blocker
> Fix For: 0.92.0
>
> Attachments: D645.1.patch
>
>
> Upping priority, and putting it against 0.92 since J-D fingered it as blocker. Which metrics in particular are missing? Hard to patch?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira