You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by Christian Haul <ha...@dvs1.informatik.tu-darmstadt.de> on 2001/06/26 16:48:52 UTC

[Patch][C2.1] sitemap.xsl name translation errors + more

Hi.

Current sitemap.xsl presents three problems:

1) in matchers type is erroneously converted but compared to
   unconverted type

2) in matchers name2 is erroneously not converted thus trying to
   define java variables containing " " or "-".

   Since it appears code was copied for selectors the same problems
   occur there too.

3) If an actions has parameters defined, they are inserted before and
   after the action is called (several places).

The attached patch fixes the above.

In addition it enables parameter substitution on <map:redirect-to resource="" target="{parameter}">

	Chris.

PS: Any comments on the patch I submitted on thursday? Seems not to
    have made it. (message-id 20010621192445.I29680@bremen.dvs1.informatik.tu-darmstadt.de)

-- 
C h r i s t i a n       H a u l
haul@informatik.tu-darmstadt.de
    fingerprint: 99B0 1D9D 7919 644A 4837  7D73 FEF9 6856 335A 9E08

Re: [Patch][C2.1] sitemap.xsl name translation errors + more

Posted by Christian Haul <ha...@dvs1.informatik.tu-darmstadt.de>.
On 27.Jun.2001 -- 05:48 PM, Vadim Gritsenko wrote:
> 
> Patch applied, with minor changes. Please check that it's OK.

Vadim,

thanks a lot. Changes look convincing.

	Chris.

-- 
C h r i s t i a n       H a u l
haul@informatik.tu-darmstadt.de
    fingerprint: 99B0 1D9D 7919 644A 4837  7D73 FEF9 6856 335A 9E08

---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org


RE: [Patch][C2.1] sitemap.xsl name translation errors + more

Posted by Vadim Gritsenko <vg...@hns.com>.
Christian,

Patch applied, with minor changes. Please check that it's OK.

Vadim

> -----Original Message-----
> From: Christian Haul [mailto:haul@dvs1.informatik.tu-darmstadt.de]
> Sent: Tuesday, June 26, 2001 10:49
> To: cocoon-dev@xml.apache.org
> Subject: [Patch][C2.1] sitemap.xsl name translation errors + more
> 
> 
> Hi.
> 
> Current sitemap.xsl presents three problems:
> 
> 1) in matchers type is erroneously converted but compared to
>    unconverted type
> 
> 2) in matchers name2 is erroneously not converted thus trying to
>    define java variables containing " " or "-".
> 
>    Since it appears code was copied for selectors the same problems
>    occur there too.
> 
> 3) If an actions has parameters defined, they are inserted before and
>    after the action is called (several places).
> 
> The attached patch fixes the above.
> 
> In addition it enables parameter substitution on <map:redirect-to resource="" target="{parameter}">
> 
> 	Chris.
> 
> PS: Any comments on the patch I submitted on thursday? Seems not to
>     have made it. (message-id 20010621192445.I29680@bremen.dvs1.informatik.tu-darmstadt.de)
> 
> -- 
> C h r i s t i a n       H a u l
> haul@informatik.tu-darmstadt.de
>     fingerprint: 99B0 1D9D 7919 644A 4837  7D73 FEF9 6856 335A 9E08
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: cocoon-dev-unsubscribe@xml.apache.org
For additional commands, email: cocoon-dev-help@xml.apache.org