[GitHub] kaxil commented on issue #4432: [AIRFLOW-3622] Add ability to pass hive_conf to HiveToMysqlTransfer

[GitBox <gi...@apache.org>]

kaxil commented on issue #4432: [AIRFLOW-3622] Add ability to pass hive_conf to HiveToMysqlTransfer
URL: https://github.com/apache/airflow/pull/4432#issuecomment-451670335
 
 
   Can you please resolve an error that was in the PR but because of broken Travis it wasn't detected:
   
   ```
   ======================================================================
   33) FAIL: test_execute (tests.operators.test_hive_to_mysql.TestHiveToMySqlTransfer)
   ----------------------------------------------------------------------
      Traceback (most recent call last):
       .tox/py27-backend_mysql-env_docker/lib/python2.7/site-packages/mock/mock.py line 1305 in patched
         return func(*args, **keywargs)
       tests/operators/test_hive_to_mysql.py line 46 in test_execute
         mock_hive_hook.return_value.get_records.assert_called_once_with(self.kwargs['sql'])
       .tox/py27-backend_mysql-env_docker/lib/python2.7/site-packages/mock/mock.py line 948 in assert_called_once_with
         return self.assert_called_with(*args, **kwargs)
       .tox/py27-backend_mysql-env_docker/lib/python2.7/site-packages/mock/mock.py line 937 in assert_called_with
         six.raise_from(AssertionError(_error_message(cause)), cause)
       .tox/py27-backend_mysql-env_docker/lib/python2.7/site-packages/six.py line 737 in raise_from
         raise value
      AssertionError: Expected call: get_records('sql')
      Actual call: get_records('sql', hive_conf={})
      -------------------- >> begin captured logging << --------------------
      airflow.task.operators: INFO: Extracting data from Hive: sql
      airflow.task.operators: INFO: Inserting rows into MySQL
      airflow.task.operators: INFO: Done.
      --------------------- >> end captured logging << ---------------------
   ```
   Please fix it in the new PR.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services