[jira] [Commented] (AIRFLOW-2263) stack trace from null dag in webserver output

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-2263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16613618#comment-16613618 ] 

ASF GitHub Bot commented on AIRFLOW-2263:
-----------------------------------------

marklavrynenko-original opened a new pull request #3897: [AIRFLOW-2263] Fix 500 for null DAG
URL: https://github.com/apache/incubator-airflow/pull/3897
 
 
   ### Jira
   
   My PR addresses the following [AIRFLOW-2263](https://issues.apache.org/jira/browse/AIRFLOW-2263) 
   ### Description
   
   Remove 500-error when opening non-existent DAG in webserver UI `/admin/airflow/tree?dag_id=some_garbage`
   Return 404 response instead
   
   
   ### Tests
   My PR do not add new unit tests

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> stack trace from null dag in webserver output
> ---------------------------------------------
>
>                 Key: AIRFLOW-2263
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-2263
>             Project: Apache Airflow
>          Issue Type: Bug
>            Reporter: andy dreyfuss
>            Assignee: Mark Lavrynenko
>            Priority: Major
>
> webserver is reporting the following
> {code:java}
> Traceback (most recent call last):
> File "/path/to/a/virtualenv/lib/python3.6/site-packages/flask/app.py", line 1988, in wsgi_app
> response = self.full_dispatch_request()
> File "/path/to/a/virtualenv/lib/python3.6/site-packages/flask/app.py", line 1641, in full_dispatch_request
> rv = self.handle_user_exception(e)
> File "/path/to/a/virtualenv/lib/python3.6/site-packages/flask/app.py", line 1544, in handle_user_exception
> reraise(exc_type, exc_value, tb)
> File "/path/to/a/virtualenv/lib/python3.6/site-packages/flask/_compat.py", line 33, in reraise
> raise value
> File "/path/to/a/virtualenv/lib/python3.6/site-packages/flask/app.py", line 1639, in full_dispatch_request
> rv = self.dispatch_request()
> File "/path/to/a/virtualenv/lib/python3.6/site-packages/flask/app.py", line 1625, in dispatch_request
> return self.view_functions[rule.endpoint](**req.view_args)
> File "/path/to/a/virtualenv/lib/python3.6/site-packages/flask_admin/base.py", line 69, in inner
> return self._run_view(f, *args, **kwargs)
> File "/path/to/a/virtualenv/lib/python3.6/site-packages/flask_admin/base.py", line 368, in _run_view
> return fn(self, *args, **kwargs)
> File "/path/to/a/virtualenv/lib/python3.6/site-packages/flask_login.py", line 755, in decorated_view
> return func(*args, **kwargs)
> File "/path/to/a/virtualenv/lib/python3.6/site-packages/airflow/www/utils.py", line 356, in view_func
> return f(*args, **kwargs)
> File "/path/to/a/virtualenv/lib/python3.6/site-packages/airflow/www/utils.py", line 262, in wrapper
> return f(*args, **kwargs)
> File "/path/to/a/virtualenv/lib/python3.6/site-packages/airflow/www/views.py", line 1154, in tree
> base_date = dag.latest_execution_date or datetime.utcnow()
> AttributeError: 'NoneType' object has no attribute 'latest_execution_date'
>  
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)