[GitHub] [tvm] hogepodge commented on pull request #10249: Implementation of TVM international manual generation and automatic translation deployment

[GitBox <gi...@apache.org>]

hogepodge commented on pull request #10249:
URL: https://github.com/apache/tvm/pull/10249#issuecomment-1045455655


   I've started to build this and have a few comments on things I've noticed. The script makes some assumptions about how dependencies are installed, and calls `pip` to bring in `doctools` and `sphinx-intl`. Since there are many different ways people work with and develop TVM, I would argue that the build script should not handle installation of dependencies, rather that should be defined as a prerequisite and left to the user or build system to sort out. 
   
   Speaking more generally we should be more explicit on what configurations and prerequisites need to be set and installed for a successful docs build. For some docs we need to enable `microtvm`, or have libraries like `tensorflow`, `pytorch`, and `clang` be available for a successful build. These aren't issues with this patch in general, just with the docs build in general.
   
   Noting that some work has gone into sitemap generation, is this something that can be separated out as a side improvement?
   
   I'd like to see a specific doc added that has links to translations and also adds world-facing instructions on how to add a translation. This work deserves more visibility.
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org