You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/06/25 20:19:46 UTC
[GitHub] [airflow] AliMuhammadOfficial opened a new pull request #16668: Refactor: added type annotation
AliMuhammadOfficial opened a new pull request #16668:
URL: https://github.com/apache/airflow/pull/16668
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
Refactor: added type annotation
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #16668: Refactor: added type annotation
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16668:
URL: https://github.com/apache/airflow/pull/16668#issuecomment-869186546
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #16668: Refactor: added type annotation
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #16668:
URL: https://github.com/apache/airflow/pull/16668#discussion_r659281726
##########
File path: tests/build_provider_packages_dependencies.py
##########
@@ -114,13 +114,14 @@ class ImportFinder(NodeVisitor):
AST visitor that collects all imported names in its imports
"""
- def __init__(self, filename):
+ def __init__(self, filename: str) -> None:
+
Review comment:
```suggestion
def __init__(self, filename: str) -> None:
```
(suggested by flake8)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #16668: Refactor: added type annotation
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #16668:
URL: https://github.com/apache/airflow/pull/16668
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #16668: Refactor: added type annotation
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #16668:
URL: https://github.com/apache/airflow/pull/16668#issuecomment-869049734
Some static chceks are failling. I highly recommend to install pre-commit locally to fix them automatically
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #16668: Refactor: added type annotation
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #16668:
URL: https://github.com/apache/airflow/pull/16668#discussion_r659269759
##########
File path: tests/build_provider_packages_dependencies.py
##########
@@ -114,13 +114,14 @@ class ImportFinder(NodeVisitor):
AST visitor that collects all imported names in its imports
"""
- def __init__(self, filename):
+ def __init__(self, filename: str) -> None:
+
self.imports: List[str] = []
- self.filename = filename
+ self.filename: str = filename
Review comment:
I don’t think this is needed, Mypy is able to infer this from the argument type IIRC.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org