You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "umustafi (via GitHub)" <gi...@apache.org> on 2024/08/07 21:10:31 UTC
Re: [PR] [GOBBLIN-2127] do not emit GaaSObservabilityEvent for a failed job that is going to be retried [gobblin]
umustafi commented on code in PR #4018:
URL: https://github.com/apache/gobblin/pull/4018#discussion_r1707915249
##########
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/KafkaJobStatusMonitor.java:
##########
@@ -228,7 +228,10 @@ protected void processMessage(DecodeableKafkaRecord<byte[],byte[]> message) {
String tableName = jobStatusTableName(flowExecutionId, jobGroup, jobName);
String status = jobStatus.getProp(JobStatusRetriever.EVENT_NAME_FIELD);
- if (updatedJobStatus.getRight() == NewState.FINISHED) {
+ boolean retryRequired = modifyStateIfRetryRequired(jobStatus);
Review Comment:
this bug is hard to follow can u comment why the state check was moved here so it is not changed in the future
##########
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/KafkaJobStatusMonitor.java:
##########
@@ -228,7 +228,10 @@ protected void processMessage(DecodeableKafkaRecord<byte[],byte[]> message) {
String tableName = jobStatusTableName(flowExecutionId, jobGroup, jobName);
String status = jobStatus.getProp(JobStatusRetriever.EVENT_NAME_FIELD);
- if (updatedJobStatus.getRight() == NewState.FINISHED) {
+ boolean retryRequired = modifyStateIfRetryRequired(jobStatus);
+
+ if (updatedJobStatus.getRight() == NewState.FINISHED && !retryRequired) {
+ // do not send event if retry is required, because it can alert users to re-submit a job that is already set to be retried by GaaS
Review Comment:
helpful comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org