[GitHub] [incubator-superset] DiggidyDave edited a comment on issue #7748: [SIP-23] Move SQL Lab storage out of browser localStorage

[GitBox <gi...@apache.org>]

DiggidyDave edited a comment on issue #7748: [SIP-23] Move SQL Lab storage out of browser localStorage
URL: https://github.com/apache/incubator-superset/issues/7748#issuecomment-505997853
 
 
   I suggest keeping the narrative clean, stick to the general principle of this SIP, and NOT use local storage. What about?
   
   - put a guid on TabState
   - have browser do conditional PUT for TabState, if the GUID doesn't match then fail write and query latest/correct state 
   - on `window.focus` fetch latest state, to make sure user doesn't start working on top of stale state
   - on `window.blur` (visible but not focus) poll for updates
   - handle `onvisibilitychange`to stop polling (if not visible) or transition to correct state if becoming visible
   
   The last 3 bullets make a foundational assumption that a user will not be simultaneously editing in 2 windows. They may have 2 windows open, even side by side on the same screen, but they will only have focus and be actively typing in one of them.
   
   EDIT to note: thie TL;DR of this is that when you are typing, if another editor window is open and visible, it will update at the polling frequency to reflect what you are typing in the focus window.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org