You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Vinayakumar B (JIRA)" <ji...@apache.org> on 2015/06/04 15:02:38 UTC
[jira] [Commented] (HDFS-5887) Add suffix to generated protobuf
class
[ https://issues.apache.org/jira/browse/HDFS-5887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14572717#comment-14572717 ]
Vinayakumar B commented on HDFS-5887:
-------------------------------------
Can any expert in PB confirm, whether changing the PB message name (ClassName) in Protobuf generated code affect compatibility with older versions?
Whether it can still identify old messages?
I understand that PB supports wire compatibility for the optional fields in a Message, But what if Message name itself changed?
If there is a compatibility issue, then this issue will be invalid IMO.
> Add suffix to generated protobuf class
> --------------------------------------
>
> Key: HDFS-5887
> URL: https://issues.apache.org/jira/browse/HDFS-5887
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Affects Versions: HDFS-5698 (FSImage in protobuf)
> Reporter: Haohui Mai
> Assignee: Tassapol Athiapinya
> Priority: Minor
> Labels: BB2015-05-TBR
> Attachments: HDFS-5887.000.patch, HDFS-5887.000.proto_files-only.patch, HDFS-5887.001.patch
>
>
> As suggested by [~tlipcon], the code is more readable if we give each class generated by the protobuf the suffix "Proto".
> This jira proposes to rename the classes and to introduce no functionality changes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)