You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/09/07 08:40:27 UTC
[GitHub] [hive] szlta commented on a change in pull request #2619: HIVE-25502: Cleaner causes data loss when processing aborted txn with DP
szlta commented on a change in pull request #2619:
URL: https://github.com/apache/hive/pull/2619#discussion_r703304664
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Cleaner.java
##########
@@ -321,6 +321,9 @@ private boolean removeFiles(String location, ValidWriteIdList writeIdList, Compa
ci.setWriteIds(dir.getAbortedWriteIds());
}
obsoleteDirs.addAll(dir.getAbortedDirectories());
+ if (isDynPartAbort(table, ci)) {
+ obsoleteDirs = dir.getAbortedDirectories();
Review comment:
Could we add a small explanation comment here why obsoleteDirs has to be overwritten for isDynPartAbort case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org