You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "bugraoz93 (via GitHub)" <gi...@apache.org> on 2025/09/19 22:15:13 UTC

[PR] Add limit parameter to list methods and amend update method name for dags [airflow]

bugraoz93 opened a new pull request, #55912:
URL: https://github.com/apache/airflow/pull/55912

   - Handle the limit when it is passed and not use from params before calling the method which causes a bug
   - Amend method name to match update methods the same name
   
   <!--
    Licensed to the Apache Software Foundation (ASF) under one
    or more contributor license agreements.  See the NOTICE file
    distributed with this work for additional information
    regarding copyright ownership.  The ASF licenses this file
    to you under the Apache License, Version 2.0 (the
    "License"); you may not use this file except in compliance
    with the License.  You may obtain a copy of the License at
   
      http://www.apache.org/licenses/LICENSE-2.0
   
    Unless required by applicable law or agreed to in writing,
    software distributed under the License is distributed on an
    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    KIND, either express or implied.  See the License for the
    specific language governing permissions and limitations
    under the License.
    -->
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   
   
   <!-- Please keep an empty line above the dashes. -->
   ---
   **^ Add meaningful description above**
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add limit parameter to list methods and amend update method name for dags [airflow]

Posted by "bugraoz93 (via GitHub)" <gi...@apache.org>.
bugraoz93 commented on PR #55912:
URL: https://github.com/apache/airflow/pull/55912#issuecomment-3330031507

   @Prab-27, this is not the same case. This should be 
   from your example 
   
   > ```
   > def list(self, dag_id: str) -> BackfillCollectionResponse | ServerResponseError:
   >         """List all backfills."""
   >         params = {"dag_id": dag_id}
   >         return super().execute_list(path="backfills", data_model=BackfillCollectionResponse,limit= 89,params=params)
   > ```
   
   to
   
   > ```
   > def list(self, dag_id: str, limit: int) -> BackfillCollectionResponse | ServerResponseError:
   >         """List all backfills."""
   >         params = {"dag_id": dag_id}
   >         return super().execute_list(path="backfills", data_model=BackfillCollectionResponse,limit=limit,params=params)
   > ```
   
   In your example, you are passing an integer to a method, not taking from the user via ctl. Is your variable list operation method also passing the limit in this way?
   
   I have tested both in my environment using `uv pip install` and `uv sync`, as well as inside the Breeze container to ensure not Python version related that depends on the environment (Breeze using 3.10, mine 3.11). Still getting the below error.
   
   ```
   root@fc15164871a6:/opt/airflow# airflowctl variables list
   Please enter password for encrypted keyring: 
   2025-09-24 17:43:06 [warning  ] Server error                   [airflowctl.api.client] extra={'detail': [{'type': 'int_parsing', 'loc': ['query', 'limit'], 'msg': 'Input should be a valid integer, unable to parse string as an integer', 'input': ''}]}                                                                                                                                                                                                              
   Server response error: Client error message: {'detail': [{'type': 'int_parsing', 'loc': ['query', 'limit'], 'msg': 'Input should be a valid integer, unable to parse string as an integer', 'input': ''}]}
   Client error,  Please check the command and its parameters. If you need help, run the command with --help.
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add limit parameter to list methods [airflow]

Posted by "Prab-27 (via GitHub)" <gi...@apache.org>.
Prab-27 commented on PR #55912:
URL: https://github.com/apache/airflow/pull/55912#issuecomment-3371977795

   @bugraoz93 ,I'm just curious—are we also planning to add --limit as an optional command? Like: 
   `airflowctl variables list --limit=90` Can the user add it like this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add limit parameter to list methods and amend update method name for dags [airflow]

Posted by "Prab-27 (via GitHub)" <gi...@apache.org>.
Prab-27 commented on PR #55912:
URL: https://github.com/apache/airflow/pull/55912#issuecomment-3326124094

   @bugraoz93 , When I tried to reproduce it, it showed me the default value instead of the updated one—or maybe I made a mistake?
   
   ```
   limit: int | None = 50,
           params: dict | None = None,
       ) -> T | ServerResponseError:
           print(f"Limit {limit}")
   ```
           
          
   ```
   def list(self, dag_id: str) -> BackfillCollectionResponse | ServerResponseError:
           """List all backfills."""
           params = {"dag_id": dag_id}
           return super().execute_list(path="backfills", data_model=BackfillCollectionResponse,limit= 89,params=params)
   ```
           
   ```
   
   root@f60f2d0436c4:/opt/airflow# airflowctl variables list
   Please enter password for encrypted keyring:
   Limit 50
   []
   ```
           
           


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add limit parameter to list methods and amend update method name for dags [airflow]

Posted by "ashb (via GitHub)" <gi...@apache.org>.
ashb commented on code in PR #55912:
URL: https://github.com/apache/airflow/pull/55912#discussion_r2370271342


##########
airflow-ctl/src/airflowctl/api/operations.py:
##########
@@ -170,14 +170,20 @@ def execute_list(
         path: str,
         data_model: type[T],
         offset: int = 0,
-        limit: int = 50,
+        limit: int | None = None,
         params: dict | None = None,
     ) -> T | ServerResponseError:
+        limit_flag = True if limit is not None else False
+        if limit is None:
+            limit = 50
+        if params is None:
+            params = {"limit": limit}

Review Comment:
   Not having much context here, this might be a silly question:
   
   If params is passed shouldn't we add in the `limit` param too?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add limit parameter to list methods and amend update method name for dags [airflow]

Posted by "bugraoz93 (via GitHub)" <gi...@apache.org>.
bugraoz93 commented on code in PR #55912:
URL: https://github.com/apache/airflow/pull/55912#discussion_r2370545439


##########
airflow-ctl/src/airflowctl/api/operations.py:
##########
@@ -170,14 +170,20 @@ def execute_list(
         path: str,
         data_model: type[T],
         offset: int = 0,
-        limit: int = 50,
+        limit: int | None = None,
         params: dict | None = None,
     ) -> T | ServerResponseError:
+        limit_flag = True if limit is not None else False
+        if limit is None:
+            limit = 50
+        if params is None:
+            params = {"limit": limit}

Review Comment:
   This is a good question. I updated the code to add the limit in any case



##########
airflow-ctl/src/airflowctl/api/operations.py:
##########
@@ -170,14 +170,20 @@ def execute_list(
         path: str,
         data_model: type[T],
         offset: int = 0,
-        limit: int = 50,
+        limit: int | None = None,
         params: dict | None = None,
     ) -> T | ServerResponseError:
+        limit_flag = True if limit is not None else False
+        if limit is None:
+            limit = 50

Review Comment:
   I tried this before and got this error. The problem is that when the limit isn't passed to the CLI, meaning to operations, the value is coming `None`. This means that from upstream, it passed as `None` in any case, skipping the default in the signature. That's why I left this ugly notation for now 
   ```python
   ...
           limit: int | None = 50,
           params: dict | None = None,
       ) -> T | ServerResponseError:
           limit_flag = True if limit is not None else False
           print(f"Limit: {limit}")
           if params is None:
               params = {"limit": limit}
   ...
   ```
   
   Error:
   ```bash
   (airflow) bugra@dev:~/PycharmProjects/airflow$ airflowctl variables list -o table
   Limit: None
   2025-09-23 00:49:57 [warning  ] Server error                   [airflowctl.api.client] extra={'detail': [{'type': 'int_parsing', 'loc': ['query', 'limit'], 'msg': 'Input should be a valid integer, unable to parse string as an integer', 'input': ''}]}      
   ```
   I have updated as `limit = limit or 50` which looks better :) 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add limit parameter to list methods [airflow]

Posted by "bugraoz93 (via GitHub)" <gi...@apache.org>.
bugraoz93 commented on PR #55912:
URL: https://github.com/apache/airflow/pull/55912#issuecomment-3382065476

   > @bugraoz93 ,I'm just curious—are we also planning to add --limit as an optional command? Like: 
   > `airflowctl variables list --limit=90` Can the user add it like this?
   
   Yes, this PR is also adding that feature. While including it aims to make it optional. So in case it passed as None means not in command, it will fill it 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add limit parameter to list methods [airflow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #55912:
URL: https://github.com/apache/airflow/pull/55912#issuecomment-4061800580

   This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add limit parameter to list methods [airflow]

Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on code in PR #55912:
URL: https://github.com/apache/airflow/pull/55912#discussion_r2730555036


##########
airflow-ctl/src/airflowctl/api/operations.py:
##########
@@ -170,14 +170,17 @@ def execute_list(
         path: str,
         data_model: type[T],
         offset: int = 0,
-        limit: int = 50,
+        limit: int | None = None,

Review Comment:
   Why not just keep `limit=50`? Additional logic here seems entirely unnecessary to me.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add limit parameter to list methods [airflow]

Posted by "bugraoz93 (via GitHub)" <gi...@apache.org>.
bugraoz93 commented on PR #55912:
URL: https://github.com/apache/airflow/pull/55912#issuecomment-3336313339

   Will move `amend update method name for dags` to another PR, which is needed for 1.0.0. Other parts can stay


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add limit parameter to list methods [airflow]

Posted by "bugraoz93 (via GitHub)" <gi...@apache.org>.
bugraoz93 commented on PR #55912:
URL: https://github.com/apache/airflow/pull/55912#issuecomment-3352718298

   No worries @Prab-27, this won't lend on to the initial release we still have time for this, we can aim for 1.0.1 so no rush :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add limit parameter to list methods [airflow]

Posted by "bugraoz93 (via GitHub)" <gi...@apache.org>.
bugraoz93 commented on PR #55912:
URL: https://github.com/apache/airflow/pull/55912#issuecomment-3382071010

   > ```
   > root@6d9aca209fd4:/opt/airflow# airflowctl variables list
   > Please enter password for encrypted keyring:
   > Limit: None
   > 2025-10-06 03:57:08 [warning  ] Server error                   [airflowctl.api.client] extra={'detail': [{'type': 'int_parsing', 'loc': ['query', 'limit'], 'msg': 'Input should be a valid integer, unable to parse string as an integer', 'input': ''}]}
   > Server response error: Client error message: {'detail':
   > [{'type': 'int_parsing', 'loc': ['query', 'limit'],
   > 'msg': 'Input should be a valid integer, unable to parse
   > string as an integer', 'input': ''}]}
   > Client error,  Please check the command and its
   > parameters. If you need help, run the command with
   > --help.
   > ```
   > 
   > ```
   > limit: int | None = 50,
   >         params: dict | None = None,
   >     ) -> T | ServerResponseError:
   >         limit_flag = True if limit is not None else False
   >         print(f"Limit: {limit}")
   >         if params is None:
   >             params = {"limit": limit}
   > ```
   >             
   >  ```
   >  def list(self,limit:int) -> VariableCollectionResponse | ServerResponseError:
   >         """List all variables."""
   >         return super().execute_list(path="variables", data_model=VariableCollectionResponse,limit=limit)
   > ```
   > 
   > @bugraoz93, Sorry I didn’t understand that we were trying to pass it as a function argument. 
   > Now I’m getting the same error message
   > 
   >            
   >  
   
   Thanks for checking @Prab-27! This is exactly why I followed that ugly approach rather than making it the default in the method definition. We can find and fix this at a later stage and keep it like this for a while
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add limit parameter to list methods and amend update method name for dags [airflow]

Posted by "bugraoz93 (via GitHub)" <gi...@apache.org>.
bugraoz93 commented on PR #55912:
URL: https://github.com/apache/airflow/pull/55912#issuecomment-3329905237

   > @bugraoz93 , When I tried to reproduce it, it showed me the default value instead of the updated one—or maybe I made a mistake?
   > 
   > ```
   > limit: int | None = 50,
   >         params: dict | None = None,
   >     ) -> T | ServerResponseError:
   >         print(f"Limit {limit}")
   > ```
   >         
   >        
   > ```
   > def list(self, dag_id: str) -> BackfillCollectionResponse | ServerResponseError:
   >         """List all backfills."""
   >         params = {"dag_id": dag_id}
   >         return super().execute_list(path="backfills", data_model=BackfillCollectionResponse,limit= 89,params=params)
   > ```
   >         
   > ```
   > 
   > root@f60f2d0436c4:/opt/airflow# airflowctl variables list
   > Please enter password for encrypted keyring:
   > Limit 50
   > []
   > ```
   >         
   >         
   
   Thanks @Prab-27! Indeed, this is strange. Let me clean my environment and try again to see if something is wrong
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add limit parameter to list methods [airflow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #55912:
URL: https://github.com/apache/airflow/pull/55912#issuecomment-3797457024

   This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add limit parameter to list methods and amend update method name for dags [airflow]

Posted by "ashb (via GitHub)" <gi...@apache.org>.
ashb commented on code in PR #55912:
URL: https://github.com/apache/airflow/pull/55912#discussion_r2370269695


##########
airflow-ctl/src/airflowctl/api/operations.py:
##########
@@ -170,14 +170,20 @@ def execute_list(
         path: str,
         data_model: type[T],
         offset: int = 0,
-        limit: int = 50,
+        limit: int | None = None,
         params: dict | None = None,
     ) -> T | ServerResponseError:
+        limit_flag = True if limit is not None else False
+        if limit is None:
+            limit = 50

Review Comment:
   Why not leave the default of 50 in the signature?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add limit parameter to list methods [airflow]

Posted by "bugraoz93 (via GitHub)" <gi...@apache.org>.
bugraoz93 commented on PR #55912:
URL: https://github.com/apache/airflow/pull/55912#issuecomment-3801697796

   Thanks @Prab-27! Looking forward to seeing it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add limit parameter to list methods [airflow]

Posted by "Prab-27 (via GitHub)" <gi...@apache.org>.
Prab-27 commented on PR #55912:
URL: https://github.com/apache/airflow/pull/55912#issuecomment-3799204937

   Not stale !! @bugraoz93 will work at the appropriate time. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add limit parameter to list methods [airflow]

Posted by "Prab-27 (via GitHub)" <gi...@apache.org>.
Prab-27 commented on PR #55912:
URL: https://github.com/apache/airflow/pull/55912#issuecomment-3371819928

   ```
   root@6d9aca209fd4:/opt/airflow# airflowctl variables list
   Please enter password for encrypted keyring:
   Limit: None
   2025-10-06 03:57:08 [warning  ] Server error                   [airflowctl.api.client] extra={'detail': [{'type': 'int_parsing', 'loc': ['query', 'limit'], 'msg': 'Input should be a valid integer, unable to parse string as an integer', 'input': ''}]}
   Server response error: Client error message: {'detail':
   [{'type': 'int_parsing', 'loc': ['query', 'limit'],
   'msg': 'Input should be a valid integer, unable to parse
   string as an integer', 'input': ''}]}
   Client error,  Please check the command and its
   parameters. If you need help, run the command with
   --help.
   ```
   
   ```
   limit: int | None = 50,
           params: dict | None = None,
       ) -> T | ServerResponseError:
           limit_flag = True if limit is not None else False
           print(f"Limit: {limit}")
           if params is None:
               params = {"limit": limit}
   ```
               
    ```
    def list(self,limit:int) -> VariableCollectionResponse | ServerResponseError:
           """List all variables."""
           return super().execute_list(path="variables", data_model=VariableCollectionResponse,limit=limit)
   ```
   
   @bugraoz93, Sorry I didn’t understand that we were trying to pass it as a function argument. 
   Now I’m getting the same error message
   
              
    


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add limit parameter to list methods and amend update method name for dags [airflow]

Posted by "bugraoz93 (via GitHub)" <gi...@apache.org>.
bugraoz93 commented on code in PR #55912:
URL: https://github.com/apache/airflow/pull/55912#discussion_r2376619495


##########
airflow-ctl/src/airflowctl/api/operations.py:
##########
@@ -170,14 +170,20 @@ def execute_list(
         path: str,
         data_model: type[T],
         offset: int = 0,
-        limit: int = 50,
+        limit: int | None = None,
         params: dict | None = None,
     ) -> T | ServerResponseError:
+        limit_flag = True if limit is not None else False
+        if limit is None:
+            limit = 50
+        if params is None:
+            params = {"limit": limit}

Review Comment:
   I am sorry! I made the changes, rebased from main, but used the push rather than force push:facepalm: Pushing in a moment 



##########
airflow-ctl/src/airflowctl/api/operations.py:
##########
@@ -170,14 +170,20 @@ def execute_list(
         path: str,
         data_model: type[T],
         offset: int = 0,
-        limit: int = 50,
+        limit: int | None = None,
         params: dict | None = None,
     ) -> T | ServerResponseError:
+        limit_flag = True if limit is not None else False
+        if limit is None:
+            limit = 50
+        if params is None:
+            params = {"limit": limit}

Review Comment:
   I am sorry! I made the changes, rebased from main, but used the push rather than force push :facepalm: Pushing in a moment 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add limit parameter to list methods [airflow]

Posted by "Prab-27 (via GitHub)" <gi...@apache.org>.
Prab-27 commented on PR #55912:
URL: https://github.com/apache/airflow/pull/55912#issuecomment-3351786085

   @bugraoz93 ,
   I'm very sorry—I went out of town and didn’t have any network connection, so I missed it. I’ll check soon


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add limit parameter to list methods [airflow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #55912:
URL: https://github.com/apache/airflow/pull/55912#issuecomment-3567193622

   This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add limit parameter to list methods [airflow]

Posted by "bugraoz93 (via GitHub)" <gi...@apache.org>.
bugraoz93 commented on PR #55912:
URL: https://github.com/apache/airflow/pull/55912#issuecomment-3567892378

   Not stale. Merged the changes related to not sending none values. This should be straightforward but some other priorities have a bit precedence at the moment


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add limit parameter to list methods [airflow]

Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on code in PR #55912:
URL: https://github.com/apache/airflow/pull/55912#discussion_r2730557906


##########
airflow-ctl/src/airflowctl/api/operations.py:
##########
@@ -170,14 +170,17 @@ def execute_list(
         path: str,
         data_model: type[T],
         offset: int = 0,
-        limit: int = 50,
+        limit: int | None = None,

Review Comment:
   Actually, all calls seem to supply `limit` anyway so it can just be `limit: int` without a default?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org