You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@yunikorn.apache.org by "Wilfred Spiegelenburg (Jira)" <ji...@apache.org> on 2022/02/24 22:56:00 UTC

[jira] [Commented] (YUNIKORN-1092) IsReservedOnNode() can match wrong node

    [ https://issues.apache.org/jira/browse/YUNIKORN-1092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17497784#comment-17497784 ] 

Wilfred Spiegelenburg commented on YUNIKORN-1092:
-------------------------------------------------

Same kind of issue also exists in the node code. It does not show up as quickly as we mostly pre-build the key to check with but it is there.

Uploading a patch to fix this in both places

> IsReservedOnNode() can match wrong node
> ---------------------------------------
>
>                 Key: YUNIKORN-1092
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-1092
>             Project: Apache YuniKorn
>          Issue Type: Bug
>          Components: core - scheduler
>            Reporter: Craig Condit
>            Assignee: Wilfred Spiegelenburg
>            Priority: Major
>
> In scheduleer/objects/application.go, the IsReservedOnNode() function uses strings.HasPrefix to determine if a reservation belongs to a particular node. In the case where a node name is a prefix of another node (for example: node1 and node10), this can lead to application reservations stalling because the wrong node is chosen.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: issues-help@yunikorn.apache.org